Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

FE: ACL: Fix Idempotent_write ACL is not created #425

Merged
merged 1 commit into from
May 27, 2024

Conversation

polegkashti
Copy link
Contributor

@polegkashti polegkashti commented May 27, 2024

What changes did you make?
I changed two files that contained typos.
Fixes #424

Is there anything you'd like reviewers to focus on?
It's a small PR I don't think there's much to review :)

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • [X ] No need to

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • [X ] I have performed a self-review of my own code
  • [X ] I have commented my code, particularly in hard-to-understand areas
  • [X ] I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • [ X] My changes generate no new warnings (e.g. Sonar is happy)
  • [ X] I have added tests that prove my fix is effective or that my feature works
  • [ X] New and existing unit tests pass locally with my changes
  • [ X] Any dependent changes have been merged

Check out Contributing and Code of Conduct

@polegkashti polegkashti requested a review from a team as a code owner May 27, 2024 13:21
@kapybro kapybro bot added status/triage Issues pending maintainers triage status/triage/manual Manual triage in progress area/acl status/triage/completed Automatic triage completed and removed status/triage Issues pending maintainers triage labels May 27, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi polegkashti! 👋

Welcome, and thank you for opening your first PR in the repo!

Please wait for triaging by our maintainers.

Please take a look at our contributing guide.

@Haarolean Haarolean added scope/frontend Related to frontend changes type/bug Something isn't working and removed status/triage/manual Manual triage in progress labels May 27, 2024
@Haarolean Haarolean changed the title Fixes #424 (Idempotent write ACL not created due to typos in code) FE: ACL: Fix Idempotent_write ACL is not created May 27, 2024
@Haarolean Haarolean merged commit 1405952 into kafbat:main May 27, 2024
45 of 46 checks passed
@Haarolean
Copy link
Member

@polegkashti thanks for your first contribution to kafbat ui!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
area/acl scope/frontend Related to frontend changes status/triage/completed Automatic triage completed type/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FE: ACL: Idempotent_write ACL is not created
2 participants