Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Bugfix: SIGSEV in docker container on ARM64 #558

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

colesmith54
Copy link
Contributor

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)

  • Tried to start contributing to this repo, but was stuck with a SIGSEV in the kafka-ui container (I'm on ARM64). Found the problematic dependency and excluded it, now everything builds as expected. Unit tests are still passing.
  • Link to discord convo for context.

Is there anything you'd like reviewers to focus on?

  • Ensure that the use of azure-identity in this repo doesn't depend on netty-tcnative-boringssl-static.

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

@colesmith54 colesmith54 requested a review from a team as a code owner September 23, 2024 03:38
@kapybro kapybro bot added status/triage Issues pending maintainers triage status/triage/manual Manual triage in progress status/triage/completed Automatic triage completed and removed status/triage Issues pending maintainers triage labels Sep 23, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi colesmith54! 👋

Welcome, and thank you for opening your first PR in the repo!

Please wait for triaging by our maintainers.

Please take a look at our contributing guide.

@Haarolean Haarolean added scope/backend Related to backend changes type/bug Something isn't working and removed status/triage/manual Manual triage in progress labels Sep 23, 2024
@Haarolean Haarolean linked an issue Sep 23, 2024 that may be closed by this pull request
4 tasks
@Haarolean Haarolean added this to the 1.1 milestone Sep 23, 2024
@Haarolean Haarolean merged commit 1269803 into kafbat:main Sep 23, 2024
38 of 39 checks passed
@Haarolean
Copy link
Member

@colesmith54 thanks for your first contribution to kafbat UI! :-)

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
scope/backend Related to backend changes status/triage/completed Automatic triage completed type/bug Something isn't working
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

SIGSERV on arm-based machines
2 participants