Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

FE: Closes #535, allowing to configure cors through spring properties #574

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

FE: Closes #535, allowing to configure cors through spring properties #574

wants to merge 9 commits into from

Conversation

aditya-baldwa
Copy link

@aditya-baldwa aditya-baldwa commented Oct 5, 2024 •
edited
Loading

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)
Resoves #535

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)
lion

@aditya-baldwa aditya-baldwa requested a review from a team as a code owner October 5, 2024 11:19
@kapybro kapybro bot added status/triage Issues pending maintainers triage status/triage/manual Manual triage in progress status/triage/completed Automatic triage completed and removed status/triage Issues pending maintainers triage labels Oct 5, 2024
github-actions[bot]
github-actions bot reviewed Oct 5, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi aditya-baldwa! 👋

Welcome, and thank you for opening your first PR in the repo!

Please wait for triaging by our maintainers.

Please take a look at our contributing guide.

@Haarolean Haarolean added the hacktoberfest-accepted PRs accepted towards hacktoberfest goal and will be counted as approved label Oct 6, 2024
@Haarolean Haarolean self-assigned this Oct 9, 2024
@Haarolean Haarolean linked an issue Oct 9, 2024 that may be closed by this pull request
Allow configuring Access-Control-Allow-Origin header #535
Open
2 tasks
@aditya-baldwa
Closes kafbat#535, allowing to configure cors through spring properties
0228b5b
@aditya-baldwa
Merge remote-tracking branch 'origin/feat/535' into feat/535
5f4b6cb 
# Conflicts:
#	api/src/main/java/io/kafbat/ui/config/CorsGlobalConfiguration.java
#	api/src/main/java/io/kafbat/ui/config/CorsProperties.java
#	api/src/main/resources/application.yml
@aditya-baldwa aditya-baldwa requested review from a team as code owners January 23, 2025 19:20
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@Haarolean Haarolean Awaiting requested review from Haarolean

Requested changes must be addressed to merge this pull request.

Assignees

@Haarolean Haarolean

Labels
hacktoberfest-accepted PRs accepted towards hacktoberfest goal and will be counted as approved status/triage/completed Automatic triage completed status/triage/manual Manual triage in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow configuring Access-Control-Allow-Origin header
2 participants
@aditya-baldwa @Haarolean