Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

BE: Closes #71 Messages: Show headers duplicates #640

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

PopClom
Copy link

@PopClom PopClom commented Oct 29, 2024

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)
Closes #71
Added support for duplicate header keys. If a header holds a single value, it is represented as a string (as it currently works). If it holds multiple values, it's represented as a list of strings. Also added a quick example in the smart filter info modal.

Screenshot 2024-10-29 alle 23 18 22 Screenshot 2024-10-29 alle 23 25 15

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)
Screenshot 2024-10-29 alle 23 57 45

@PopClom PopClom requested review from a team as code owners October 29, 2024 23:03
@kapybro kapybro bot added status/triage Issues pending maintainers triage status/triage/manual Manual triage in progress area/messages status/triage/completed Automatic triage completed and removed status/triage Issues pending maintainers triage labels Oct 29, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi PopClom! 👋

Welcome, and thank you for opening your first PR in the repo!

Please wait for triaging by our maintainers.

Please take a look at our contributing guide.

@Haarolean Haarolean self-assigned this Nov 7, 2024
return headers;
}

private byte[] valueToBytes(Object value) {
if (value instanceof List<?> || value instanceof Map<?, ?>) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this doesn't look good. I believe in case we have one header value we still have to have a list but of one single element.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I implemented it this way to ensure headers can still be passed in the same format as before. Otherwise, users would always need to provide a list, which could break compatibility with existing inputs.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

backward compatibility issues are less evil here

@Haarolean Haarolean removed their assignment Feb 11, 2025
@Haarolean Haarolean added type/enhancement En enhancement/improvement to an already existing feature scope/backend Related to backend changes and removed status/triage/manual Manual triage in progress labels Feb 11, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
area/messages scope/backend Related to backend changes status/triage/completed Automatic triage completed type/enhancement En enhancement/improvement to an already existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BE: Messages: Show headers duplicates
2 participants