Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Infra: FE: Bump pnpm to 9.15.0 #709

Merged
merged 1 commit into from
Dec 16, 2024
Merged

Infra: FE: Bump pnpm to 9.15.0 #709

merged 1 commit into from
Dec 16, 2024

Conversation

yeikel
Copy link
Collaborator

@yeikel yeikel commented Dec 13, 2024

What changes did you make? (Give an overview)

Upgrades pnpm to the latest version(9.15.0)

Besides the expected upstream patches in pnpm , it also unblocks dependabot upgrades

See dependabot/dependabot-core#11124

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

A picture of a cute animal (not mandatory but encouraged)

cute-red-panda

@kapybro kapybro bot added status/triage Issues pending maintainers triage status/triage/manual Manual triage in progress scope/infra CI, CD, dev. env, etc. status/triage/completed Automatic triage completed and removed status/triage Issues pending maintainers triage labels Dec 13, 2024
@yeikel yeikel force-pushed the pnpm-9.15.0 branch 3 times, most recently from 08f1fe5 to 5a6564a Compare December 13, 2024 05:01
@yeikel yeikel marked this pull request as ready for review December 13, 2024 05:03
@yeikel yeikel requested review from a team as code owners December 13, 2024 05:03
@yeikel
Copy link
Collaborator Author

yeikel commented Dec 13, 2024

The build failure is due to pull_request_target as it is using the version of the workflow from main where 9.11.0 is still used

Haarolean
Haarolean previously approved these changes Dec 15, 2024
@Haarolean Haarolean added type/chore Boring stuff, could be refactoring or tech debt and removed status/triage/manual Manual triage in progress labels Dec 15, 2024
@Haarolean Haarolean added this to the 1.1 milestone Dec 15, 2024
@Haarolean
Copy link
Member

@yeikel should we merged given the open discussion in dependabot/dependabot-core#11124 ?

@yeikel
Copy link
Collaborator Author

yeikel commented Dec 15, 2024

@yeikel should we merged given the open discussion in dependabot/dependabot-core#11124 ?

Yes

But I think that we should remove the enforcement in a follow-up PR

I can update this one, too, if you prefer

@Haarolean Haarolean self-requested a review December 16, 2024 15:38
@Haarolean Haarolean merged commit 8e63f1a into kafbat:main Dec 16, 2024
6 of 7 checks passed
@yeikel yeikel deleted the pnpm-9.15.0 branch December 16, 2024 19:52
K-Diger pushed a commit to K-Diger/kafbat-kafka-ui that referenced this pull request Dec 20, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
scope/infra CI, CD, dev. env, etc. status/triage/completed Automatic triage completed type/chore Boring stuff, could be refactoring or tech debt
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants