Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

FE: Messages: Add 'copy to clipboard' button for textareas of a message #721

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

p-eye
Copy link
Contributor

@p-eye p-eye commented Dec 22, 2024

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)
Add a clipboard button for copy the contents (#626)
Resolves #626
I continued to use the existing useDataSaver, which stores all message metadata.
image

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)
copy cats 😄
image

@p-eye p-eye requested a review from a team as a code owner December 22, 2024 01:48
@kapybro kapybro bot added status/triage Issues pending maintainers triage status/triage/manual Manual triage in progress area/messages status/triage/completed Automatic triage completed and removed status/triage Issues pending maintainers triage labels Dec 22, 2024
@Haarolean Haarolean added type/enhancement En enhancement/improvement to an already existing feature scope/frontend Related to frontend changes area/ux User experiense issues and removed status/triage/manual Manual triage in progress labels Dec 24, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
area/messages area/ux User experiense issues scope/frontend Related to frontend changes status/triage/completed Automatic triage completed type/enhancement En enhancement/improvement to an already existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FE: Messages: Add 'copy to clipboard' button for textareas of a message
2 participants