Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

FE: Fix broker list when disk usage is unknown #97

Merged
merged 3 commits into from
Feb 14, 2024
Merged

Conversation

Vixtir
Copy link
Contributor

@Vixtir Vixtir commented Feb 3, 2024

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)
Fixed logic for brokers table. Forming the table now strongly depends on a brokers list, not a diskUsage information.
For any broker that doesn't have corresponding diskUsage information (segmentSize, segmentCount) will be used default string: N/A

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

@kapybro kapybro bot added status/triage Issues pending maintainers triage status/triage/manual Manual triage in progress labels Feb 3, 2024
@kapybro kapybro bot added scope/backend Related to backend changes type/feature A brand new feature status/triage/completed Automatic triage completed and removed status/triage Issues pending maintainers triage labels Feb 3, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello there Vixtir! 👋

Thank you and congrats 🎉 for opening your first PR on this project! ✨ 💖

We will try to review it soon!

@Haarolean Haarolean requested a review from Mgrdich February 3, 2024 12:47
@Haarolean Haarolean assigned Vixtir and unassigned Haarolean Feb 3, 2024
@Haarolean Haarolean added scope/frontend Related to frontend changes type/bug Something isn't working and removed scope/backend Related to backend changes type/feature A brand new feature status/triage/manual Manual triage in progress labels Feb 3, 2024
@Haarolean Haarolean linked an issue Feb 14, 2024 that may be closed by this pull request
@Haarolean Haarolean merged commit a45dd4f into main Feb 14, 2024
4 of 8 checks passed
@Haarolean Haarolean deleted the fix/broker_list branch February 14, 2024 10:21
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
scope/frontend Related to frontend changes status/triage/completed Automatic triage completed type/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broker not shown in a list if disk usage is unknown for it
3 participants