Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

blockchain/vm: reject contract creation to non-empty storage root #197

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

hyeonLewis
Copy link
Contributor

Proposed changes

This PR bring EIP-7610 implementation. Please refer to original implementation here.

Both EIP-684 and EIP-6710 apply retroactively for all blocks since genesis in Ethereum. In Kaia, since we already decided to introduce EIP-684 in Shanghai hardfork (not from genesis), I added EIP-6710 in Shanghai to align the activation. If you have other opinions, please let me know.

Types of changes

Please put an x in the boxes related to your change.

  • Bugfix
  • New feature or enhancement
  • Others

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING GUIDELINES doc
  • I have read the CLA and signed by comment I have read the CLA Document and I hereby sign the CLA in first time contribute
  • Lint and unit tests pass locally with my changes ($ make test)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Related issues

  • Please leave the issue numbers or links related to this PR here.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@hyeonLewis hyeonLewis merged commit 0a06768 into kaiachain:dev Jan 2, 2025
11 checks passed
@hyeonLewis hyeonLewis deleted the eip-7610 branch January 2, 2025 05:44
@github-actions github-actions bot locked and limited conversation to collaborators Jan 2, 2025
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants