Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Split yip config dirs from user config dirs #562

Merged
merged 3 commits into from
Sep 26, 2024
Merged

Conversation

jimmykarily
Copy link
Contributor

as per the comment here:

#550 (comment)

as per the comment here:

#550 (comment)

Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
@jimmykarily jimmykarily requested a review from a team September 26, 2024 11:32
Copy link

codecov bot commented Sep 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 49.70%. Comparing base (99e8509) to head (d3c864c).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
pkg/constants/constants.go 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #562      +/-   ##
==========================================
- Coverage   49.71%   49.70%   -0.02%     
==========================================
  Files          48       48              
  Lines        4584     4585       +1     
==========================================
  Hits         2279     2279              
- Misses       2028     2029       +1     
  Partials      277      277              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

so that we allow users to override baked-in livecd configuration with
config coming from datasource (written in /oem)

Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
@jimmykarily jimmykarily merged commit cd5ab69 into main Sep 26, 2024
14 checks passed
@jimmykarily jimmykarily deleted the split-yip-config-dirs branch September 26, 2024 12:08
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants