Fix test printing old value for debugging #2855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShouldNot(Equal(currentVersion), out) is a method call and as such, it received the value of `out` at the time of the call. That was not the updated value after the `Eventually` timeout had passed but rather the value from the previous call that populated it. This made the test output very confusing because, even though the upgrade Pod was erroring out, the output shows the cluster being only some seconds old and the pod still being created (ouch!) Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
of passing old value instead of func Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
Itxaka
approved these changes
Sep 13, 2024
renovate bot
referenced
this pull request
in marinatedconcrete/config
Sep 22, 2024
This PR contains the following updates: | Package | Update | Change | |---|---|---| | [kairos-io/kairos](https://github.com/kairos-io/kairos) | patch | `v3.1.2` -> `v3.1.3` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>kairos-io/kairos (kairos-io/kairos)</summary> ### [`v3.1.3`](https://github.com/kairos-io/kairos/releases/tag/v3.1.3) [Compare Source](https://github.com/kairos-io/kairos/compare/v3.1.2...v3.1.3) ##### Release highlights: - In the previous release, we introduced a fix for the broken permissions of the user's home directory. It turned out that the fix only applied to users created by the top level `users:` key in the Kairos configuration file. In this release, users created in various stages will also get their home directory permissions fixed. If for some reason, you don't want [the script]() to recursively fix the home directory permissions, you can create [a sentinel file](https://github.com/kairos-io/packages/blob/2fce89f6499a722768b1c58b6eace5ed7e45742d/packages/static/kairos-overlay-files/files/usr/bin/fix-home-dir-ownership#L5-L7) to skip the fix and apply it on your own as you see fit. - Fixed an issue where we didn't calculate the upgrade image size and the always created an image with the default size ([https://github.com/kairos-io/kairos/issues/2818](https://github.com/kairos-io/kairos/issues/2818)) - Fixed an issue in Kairos upgrades through Kuberentes, where various host directories were also used in image size calculation ([https://github.com/kairos-io/kairos-agent/pull/537](https://github.com/kairos-io/kairos-agent/pull/537)) - We now display the webui url below the QR code to avoid people having to plug a keyboard just to find the IP address of the node ([https://github.com/kairos-io/kairos/issues/2826](https://github.com/kairos-io/kairos/issues/2826)) - Fixed a bug in Alpine flavors where we passed the edgevpn arguments in the openrc service file wrongly ([https://github.com/kairos-io/kairos/issues/2789](https://github.com/kairos-io/kairos/issues/2789)) - Lots of version bumps on dependencies (mostly automated). ##### Known Issues - \[Carry over from previous releases] RPi EFI booting no longer supported on kernels shipped with Ubuntu 24.04+ [#​2249](https://github.com/kairos-io/kairos/issues/2249) ##### What's Changed - Add permissions to generic arm release pipeline by [@​mauromorales](https://github.com/mauromorales) in [https://github.com/kairos-io/kairos/pull/2840](https://github.com/kairos-io/kairos/pull/2840) - Update tj-actions/changed-files action to v45 by [@​renovate](https://github.com/renovate) in [https://github.com/kairos-io/kairos/pull/2816](https://github.com/kairos-io/kairos/pull/2816) - Add upgrade uki test by [@​jimmykarily](https://github.com/jimmykarily) in [https://github.com/kairos-io/kairos/pull/2776](https://github.com/kairos-io/kairos/pull/2776) - Update dependency go to v1.23.1 by [@​renovate](https://github.com/renovate) in [https://github.com/kairos-io/kairos/pull/2845](https://github.com/kairos-io/kairos/pull/2845) - Generate relative paths to files by [@​jimmykarily](https://github.com/jimmykarily) in [https://github.com/kairos-io/kairos/pull/2846](https://github.com/kairos-io/kairos/pull/2846) - 🤖 Make arm64 workers use docker mirror by [@​Itxaka](https://github.com/Itxaka) in [https://github.com/kairos-io/kairos/pull/2850](https://github.com/kairos-io/kairos/pull/2850) - 🐛 Fix wifi cloud-config example by [@​jimmyjones2](https://github.com/jimmyjones2) in [https://github.com/kairos-io/kairos/pull/2820](https://github.com/kairos-io/kairos/pull/2820) - 📖 Add alpine wifi cloud-config by [@​jimmyjones2](https://github.com/jimmyjones2) in [https://github.com/kairos-io/kairos/pull/2819](https://github.com/kairos-io/kairos/pull/2819) - Update anchore/grype Docker tag to v0.80.1 by [@​renovate](https://github.com/renovate) in [https://github.com/kairos-io/kairos/pull/2852](https://github.com/kairos-io/kairos/pull/2852) - Update aquasec/trivy Docker tag to v0.55.0 by [@​renovate](https://github.com/renovate) in [https://github.com/kairos-io/kairos/pull/2781](https://github.com/kairos-io/kairos/pull/2781) - Update aquasec/trivy Docker tag to v0.55.1 by [@​renovate](https://github.com/renovate) in [https://github.com/kairos-io/kairos/pull/2854](https://github.com/kairos-io/kairos/pull/2854) - Update github/codeql-action action to v3.26.6 by [@​renovate](https://github.com/renovate) in [https://github.com/kairos-io/kairos/pull/2799](https://github.com/kairos-io/kairos/pull/2799) - Fix test printing old value for debugging by [@​jimmykarily](https://github.com/jimmykarily) in [https://github.com/kairos-io/kairos/pull/2855](https://github.com/kairos-io/kairos/pull/2855) - Update google/osv-scanner-action action to v1.8.5 by [@​renovate](https://github.com/renovate) in [https://github.com/kairos-io/kairos/pull/2853](https://github.com/kairos-io/kairos/pull/2853) - Update quay.io/kairos/framework Docker tag to v2.11.5 by [@​renovate](https://github.com/renovate) in [https://github.com/kairos-io/kairos/pull/2856](https://github.com/kairos-io/kairos/pull/2856) - Update github/codeql-action action to v3.26.7 by [@​renovate](https://github.com/renovate) in [https://github.com/kairos-io/kairos/pull/2858](https://github.com/kairos-io/kairos/pull/2858) - Update quay.io/kairos/framework Docker tag to v2.11.7 by [@​renovate](https://github.com/renovate) in [https://github.com/kairos-io/kairos/pull/2859](https://github.com/kairos-io/kairos/pull/2859) - Split the uploading of trivy and grype results by [@​jimmykarily](https://github.com/jimmykarily) in [https://github.com/kairos-io/kairos/pull/2860](https://github.com/kairos-io/kairos/pull/2860) ##### New Contributors - [@​jimmyjones2](https://github.com/jimmyjones2) made their first contribution in [https://github.com/kairos-io/kairos/pull/2820](https://github.com/kairos-io/kairos/pull/2820) **Full Changelog**: kairos-io/kairos@v3.1.2...v3.1.3 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/marinatedconcrete/config). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC44MC4wIiwidXBkYXRlZEluVmVyIjoiMzguODAuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ShouldNot(Equal(currentVersion), out) is a method call and as such, it received the value of
outat the time of the call. That was not the updated value after theEventuallytimeout had passed but rather the value from the previous call that populated it.This made the test output very confusing because, even though the upgrade Pod was erroring out, the output shows the cluster being only some seconds old and the pod still being created (ouch!)
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #