Skip to content

Commit

Permalink
Revert "GH Actions: avoid running node vendor_build.js twice"
Browse files Browse the repository at this point in the history
This reverts commit b06c034.

After testing, it turned out that the `node vendor_build.js` after `npm
install <package-spec>...` is actually necessary (otherwise the `npm
install <package-spec>...` command has no effect on the resulting bundle
in the `out/` directory), and removing it was a mistake.
  • Loading branch information
generalmimon committed Aug 24, 2024
1 parent f968ac3 commit 0a3ba86
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ jobs:
- name: Use stable versions of KSC and JS runtime
run: |
npm install kaitai-struct-compiler@latest kaitai-struct@latest
node vendor_build.js
if: github.ref == 'refs/heads/stable'
- name: Use devel versions of KSC and JS runtime
run: |
Expand Down

0 comments on commit 0a3ba86

Please # to comment.