Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Bug: can not deal with upper case names (org & repo) properly #53

Closed
huan opened this issue Mar 6, 2020 · 3 comments
Closed

Bug: can not deal with upper case names (org & repo) properly #53

huan opened this issue Mar 6, 2020 · 3 comments
Assignees
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@huan
Copy link
Collaborator

huan commented Mar 6, 2020

Currently, we are set the config with all lowercase names:

https://github.com/kaiyuanshe/oss-bot/blob/3038422f79adbbfdf5cd850746377b0bdbd684f3/src/config.ts#L33

However, the GitHub webhook will send us an event with "full_name": "DSExtension/DSExtension".

Then when we have received the event, we have the following code:

https://github.com/kaiyuanshe/oss-bot/blob/3038422f79adbbfdf5cd850746377b0bdbd684f3/src/issue-handlers.ts#L94-L96

That's the reason why the DSExtension committers can not receive the msg card.

A solution would be converting the full_name to lowercase before we match it in our managedRepoConfig.

@huan huan added the bug Something isn't working label Mar 6, 2020
@francis-du
Copy link
Member

francis-du commented Mar 6, 2020

Same problem encountered in Quicksql

@huan huan added the good first issue Good for newcomers label Mar 6, 2020
@huan huan closed this as completed in c7c6c28 Mar 8, 2020
@huan huan reopened this Mar 8, 2020
@huan huan self-assigned this Mar 8, 2020
@huan
Copy link
Collaborator Author

huan commented Mar 8, 2020

The config should be not case sensitive anymore, this issue has been fixed by 1a7944c

@huan
Copy link
Collaborator Author

huan commented Mar 19, 2020

Presented and closed on the weekly meeting.

Thanks @zhuangbiaowei for helping me close this issue. :-D

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants