Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: Add debug mode #26

Merged
merged 2 commits into from
Dec 24, 2019
Merged

Conversation

zhuangbiaowei
Copy link
Member

I'm submitting a...

[ ] Bug Fix
[x] Feature
[ ] Other (Refactoring, Added tests, Documentation, ...)

Checklist

  • Commit Messages follow the Conventional Commits pattern
    • A feature commit message is prefixed "feat:"
    • A bugfix commit message is prefixed "fix:"
  • Tests for the changes have been added

Description

When you type: ts-node src/main.ts -d
You will not frequently send WeChat messages to disturb others.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

  When you type: ts-node src/main.ts -d
  You will not frequently send WeChat messages to disturb others.

Signed-off-by: zhuangbiaowei <zhuangbiaowei@gmail.com>
Copy link
Collaborator

@huan huan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better if we can have an issue first, then create the PR second.

LGTM

package.json Outdated
"wechaty": "^0.29.8"
"rocksdb": "^4.1.0",
"wechaty": "^0.29.8",
"wechaty-puppet": "^0.15.28",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's better to not dependence the wechaty-puppet by yourself.

It should be dependency by wechaty

package.json Outdated
"rocksdb": "^4.1.0",
"wechaty": "^0.29.8",
"wechaty-puppet": "^0.15.28",
"wechaty-puppet-padplus": "^0.1.3"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's also not the best practice to dependence the wechaty-puppet-padplus module: it would be better to be managed by wechaty itself.

@zhuangbiaowei
Copy link
Member Author

@huan

I have removed which components should not needed.

Signed-off-by: Zhuang BiaoWei <zhuangbiaowei@huawei.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants