Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

test the entire process for writting “how to use” doc #62

Merged
merged 3 commits into from
Mar 13, 2020
Merged

test the entire process for writting “how to use” doc #62

merged 3 commits into from
Mar 13, 2020

Conversation

davidzollo
Copy link

test the entire process for writting “how to use” doc

test the entire process for writting “how to use” doc
Copy link
Collaborator

@huan huan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see the CI error message at https://travis-ci.com/github/kaiyuanshe/oss-bot/builds/152849840#L256 , and we will be able to merge this PR after the CI turns green! :)

Copy link
Author

@davidzollo davidzollo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Project ascending order

@huan
Copy link
Collaborator

huan commented Mar 12, 2020

@dailidong Still has some order issues, you have almost get it fixed!

See: https://travis-ci.com/github/kaiyuanshe/osschat/builds/152980413#L255

/home/travis/build/kaiyuanshe/oss-bot/src/config.ts
  42:3  error  Expected object keys to be in ascending order. 'BUPT/ai-ml.club' should be before 'apache/incubator-iotdb'    sort-keys
  44:3  error  Expected object keys to be in ascending order. 'DSExtension/DSExtension' should be before 'dailidong/ossbot'  sort-keys

Copy link
Collaborator

@huan huan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have fixed the linting issue fo this PR.

We have very strong linting rules because that can help us keeping the code style to be consistent from different contributors.

@huan huan merged commit c7adb18 into kaiyuanshe:master Mar 13, 2020
@huan
Copy link
Collaborator

huan commented Mar 13, 2020

Cheers!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants