Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

move repo name to the end of the message title #92

Merged
merged 1 commit into from
Apr 2, 2020

Conversation

jixuan1989
Copy link
Contributor

I'm submitting a...

[ ] Bug Fix
[ x ] Feature
[ ] Other (Refactoring, Added tests, Documentation, ...)

Description

As described in #83 , I am trying to move the Repo name to the end of the message title.
It is because in many cases, the Wechat group that the message will be sent to only receives message from the same repo. In this case, the repo name is repeated in all messages.

Copy link
Collaborator

@huan huan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@huan huan merged commit bf0a644 into kaiyuanshe:master Apr 2, 2020
@huan
Copy link
Collaborator

huan commented Apr 2, 2020

Onlined.

@huan
Copy link
Collaborator

huan commented Apr 2, 2020

Oh, it seems that you have only modified the openIssue event, which will be called when a new issue is created.

If you want to change the comment of the issue UrlLink format, I believe we have to add one more modification in the commentIssue event handler.

@jixuan1989
Copy link
Contributor Author

Ok... Of course I want, let me open a new PR..

@jixuan1989 jixuan1989 deleted the issue_83 branch April 2, 2020 07:22
@huan
Copy link
Collaborator

huan commented Apr 2, 2020

Ok.

And could you please create an issue and link your PRs to that issue, so that we can have a central thread for this discussion?

Thank you very much!

@jixuan1989
Copy link
Contributor Author

I think #83 is the thread.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants