Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix error UnicodeEncode #28

Merged
merged 3 commits into from
Aug 2, 2022
Merged

fix error UnicodeEncode #28

merged 3 commits into from
Aug 2, 2022

Conversation

Divarion-D
Copy link
Contributor

Why do we need emoticons checkmarks in the log? On vds they generate an error:
UnicodeEncodeError: 'latin-1' codec can't encode character '\u2705' in position 25: ordinal not in range(256)

@sourcery-ai
Copy link

sourcery-ai bot commented Aug 2, 2022

Sourcery Code Quality Report

Merging this PR leaves code quality unchanged.

Quality metrics Before After Change
Complexity 48.22 ⛔ 48.22 ⛔ 0.00
Method Length 455.00 ⛔ 455.60 ⛔ 0.60 👎
Working memory 20.13 ⛔ 20.13 ⛔ 0.00
Quality 11.64% 11.64% 0.00%
Other metrics Before After Change
Lines 544 544 0
Changed files Quality Before Quality After Quality Change
Uploader/button.py 6.66% ⛔ 6.66% ⛔ 0.00%
Uploader/dl_button.py 17.07% ⛔ 17.07% ⛔ 0.00%

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
Uploader/button.py youtube_dl_call_back 60 ⛔ 971 ⛔ 22 ⛔ 4.82% ⛔ Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
Uploader/dl_button.py ddl_call_back 47 ⛔ 889 ⛔ 20 ⛔ 7.88% ⛔ Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
Uploader/dl_button.py download_coroutine 14 🙂 213 ⛔ 16 ⛔ 35.25% 😞 Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@kalanakt
Copy link
Owner

kalanakt commented Aug 2, 2022

A ok 👌

@kalanakt kalanakt merged commit e1743c3 into kalanakt:main Aug 2, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants