Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

AWS SNS SQS: pass FIFO message attributes to tomodachi handler function #1810

Conversation

filipsnastins
Copy link
Contributor

When working with FIFO queues and custom tomodachi middlewares, we need access to message_deduplication_id and message_group_id.

Change summary:

  • Passing message_deduplication_id and message_group_id to handler function
  • If a handler is not fifo, both attributes will be set to None

It's useful in custom SQS middlewares that, for example, move messages to dead-letter-queues and must preserve MessageDeduplicationId and MessageGroupId.

@codecov
Copy link

codecov bot commented Oct 2, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (77f2385) 73.59% compared to head (7d10773) 73.59%.
Report is 36 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1810   +/-   ##
=======================================
  Coverage   73.59%   73.59%           
=======================================
  Files          52       52           
  Lines        7646     7654    +8     
=======================================
+ Hits         5627     5633    +6     
- Misses       2019     2021    +2     
Files Coverage Δ
tomodachi/transport/aws_sns_sqs.py 66.31% <80.00%> (+0.13%) ⬆️

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kalaspuff kalaspuff merged commit f68961f into kalaspuff:master Oct 2, 2023
8 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants