General specifications check

[ghost]

This issue is part of issue #129 that aims to check various files with respect to corresponding specifications. I have already made early checking and fixed for data/*desktop.in in 4.1.2 (see commit eb3abff that is part of pull request #122 ), but that is not all.

A. Makefile

• Edit line 14 LRELEASE = lrelease and change lrelease to lrelease-qt4 to declare clearly which version of lrelease should be used;

• The latter has been checked as valid in Ubuntu packages and Debian packages that provides qt4-linguist-tools packages.

• Also confirmed on Ubuntu Trusty host system (similarly seen in Debian Jessie):

  $ which lrelease lrelease-qt4 
  /usr/bin/lrelease
  /usr/bin/lrelease-qt4
  
  $ ls -l /usr/bin/lrelease*
  lrwxrwxrwx 1 root root  9 Feb 19  2014 /usr/bin/lrelease -> qtchooser
  lrwxrwxrwx 1 root root 38 May 27  2015 /usr/bin/lrelease-qt4 -> ../lib/i386-linux-gnu/qt4/bin/lrelease
  

• This has been revised already in the forked release to be compatible with Qt 4 in 16.04 release (see commit 9045a20), so it is important to declare specific version of dependencies, similar to the way we declare PYTHON = python2

B. data/customizer.policy.in

• Revise optional element <vendor> (currently using binary file name customizer-gui; Replace with project name Customizer instead)
• Revise optional element <vendor_url> (currently using invalid URL customizer-gui; Replace with file URI scheme i.e. file:///usr/share/doc/customizer; This actually works and will open the file manager at specified path location, where customizer data is installed) -- No more hassle to update URL of project site, because of possible repo transfer and changing owner (&)
• (&) Another way is to implement substition variable likewise @PREFIX@ in Makefile, such that the variable can be set to owner/reponame for completing correct URL every time installation takes place; This is better approach to mention the URL of project at GitHub, and the variable can be reused to identify version from which repository, provided the value is set to correct forkowner/forkname in fork repository
• Revise optional element <icon_names> (currently using icon system-run is grey-ish colour and hardly noticeable to users); Replace system-run with help-about for another common icon name but with noticeable colour and shape;
• The icon may be replaced with custom icon i.e. Customizer logo, but requires to follow Freedesktop.org Specifications, which is another additional work; Since <icon_names> is optional, it may be removed in the future, if seen as useless
• Revise element <description> (replace somewhat misleading Run "customizer" with Run Customizer GUI for consistency, since pkexec is for running GUI, not command line)
• Fix indentation and position of some elements according to the polkit spec

C. src/lib/config.py

• The safe default has slightly different configuration from initial default at data/customizer.conf; Whenever Customizer recovers from error due to invalid ISO or something critical (?), safe default will replace the existing configuration
• (?) I can't remember what was the trigger; Even without the error, the said behaviour can also be reproduced by removing /etc/customizer.conf and re-run customizer-gui to recreate the configuration file with safe default
• In particular, the safe default will alter compression option from gzip to xz; This is an unexpected behaviour for me as a user, because I continue to use without realizing it has changed to xz
• Note that xz uses more CPU resources and time to rebuild ISO image as a trade off for creating relatively smaller size of ISO image; This may frustrate end users (including me) due to inconsistency of safe default configuration and increased time to rebuild after recovering from error
• Mismatch at line 16; Revise 'COMPRESSION': 'xz' to 'COMPRESSION': 'gzip' for safe default

I hope to include these fixes in patched release 4.1.3.

[ghost]

Fixed in branch repository.