Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix dangling reference warning with GCC 14. #760

Merged
merged 13 commits into from
Jan 22, 2025
Merged

Fix dangling reference warning with GCC 14. #760

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
0f63c7f
Fix dangling reference warning with GCC 14.
niklas-uhl Jan 20, 2025
6d94ba3
Remove unncessary `auto&&` in exscan.
niklas-uhl Jan 20, 2025
1df5d77
Remove unncessary `auto&&` in gather.
niklas-uhl Jan 20, 2025
9903837
Remove unnecessary `auto&&` in ireduce.
niklas-uhl Jan 20, 2025
b990632
Remove unnecessary `auto&&` in reduce.
niklas-uhl Jan 20, 2025
939524b
Remove unnecessary `auto&&` in scan.
niklas-uhl Jan 20, 2025
f735024
Remove unnecessary `auto&&` in scatter.
niklas-uhl Jan 20, 2025
b279aae
Remove unnecessary `auto&&` in allgather.
niklas-uhl Jan 20, 2025
22e576f
Remove unnecessary `auto&&` in allreduce.
niklas-uhl Jan 20, 2025
4c5a342
Remove unnecessary `auto&&` in alltoall and some includes.
niklas-uhl Jan 20, 2025
471d45a
Remove unnecessary `auto&&` in bcast.
niklas-uhl Jan 20, 2025
99f1e35
Remove unnecessary `auto&&` in neighbor alltoall.
niklas-uhl Jan 20, 2025
2301add
Remove unncessary `auto&&` and includes in p2p operations.
niklas-uhl Jan 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 14 additions & 14 deletions include/kamping/collectives/allgather.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,21 +88,21 @@ auto kamping::Communicator<DefaultContainerType, Plugins...>::allgather(Args...
);

// get the send/recv buffer and types
auto&& send_buf_param =
auto send_buf_param =
internal::select_parameter_type<internal::ParameterType::send_buf>(args...).construct_buffer_or_rebind();
auto send_buf = send_buf_param.get();
using send_value_type = typename std::remove_reference_t<decltype(send_buf_param)>::value_type;

using default_recv_buf_type = decltype(kamping::recv_buf(alloc_new<DefaultContainerType<send_value_type>>));
auto&& recv_buf =
auto recv_buf =
internal::select_parameter_type_or_default<internal::ParameterType::recv_buf, default_recv_buf_type>(
std::tuple(),
args...
)
.template construct_buffer_or_rebind<DefaultContainerType>();
using recv_value_type = typename std::remove_reference_t<decltype(recv_buf)>::value_type;

auto&& [send_type, recv_type] =
auto [send_type, recv_type] =
internal::determine_mpi_datatypes<send_value_type, recv_value_type, decltype(recv_buf)>(args...);
[[maybe_unused]] constexpr bool send_type_is_input_parameter = !has_to_be_computed<decltype(send_type)>;
[[maybe_unused]] constexpr bool recv_type_is_input_parameter = !has_to_be_computed<decltype(recv_type)>;
Expand All @@ -119,7 +119,7 @@ auto kamping::Communicator<DefaultContainerType, Plugins...>::allgather(Args...

// get the send counts
using default_send_count_type = decltype(kamping::send_count_out());
auto&& send_count =
auto send_count =
internal::select_parameter_type_or_default<internal::ParameterType::send_count, default_send_count_type>(
std::tuple(),
args...
Expand All @@ -132,7 +132,7 @@ auto kamping::Communicator<DefaultContainerType, Plugins...>::allgather(Args...

// get the receive counts
using default_recv_count_type = decltype(kamping::recv_count_out());
auto&& recv_count =
auto recv_count =
internal::select_parameter_type_or_default<internal::ParameterType::recv_count, default_recv_count_type>(
std::tuple(),
args...
Expand Down Expand Up @@ -215,11 +215,11 @@ auto kamping::Communicator<DefaultContainerType, Plugins...>::allgather_inplace(
);

// get the send/recv buffer and type
auto&& buffer =
auto buffer =
internal::select_parameter_type<internal::ParameterType::send_recv_buf>(args...).construct_buffer_or_rebind();
using value_type = typename std::remove_reference_t<decltype(buffer)>::value_type;

auto&& type = internal::determine_mpi_send_recv_datatype<value_type, decltype(buffer)>(args...);
auto type = internal::determine_mpi_send_recv_datatype<value_type, decltype(buffer)>(args...);
[[maybe_unused]] constexpr bool type_is_input_parameter = !has_to_be_computed<decltype(type)>;

KASSERT(
Expand All @@ -233,7 +233,7 @@ auto kamping::Communicator<DefaultContainerType, Plugins...>::allgather_inplace(

// get the send counts
using default_count_type = decltype(kamping::send_recv_count_out());
auto&& count =
auto count =
internal::select_parameter_type_or_default<internal::ParameterType::send_recv_count, default_count_type>(
std::tuple(),
args...
Expand Down Expand Up @@ -332,13 +332,13 @@ auto kamping::Communicator<DefaultContainerType, Plugins...>::allgatherv(Args...
);

// get send_buf
auto&& send_buf =
auto send_buf =
internal::select_parameter_type<internal::ParameterType::send_buf>(args...).construct_buffer_or_rebind();
using send_value_type = typename std::remove_reference_t<decltype(send_buf)>::value_type;

// get recv_buf
using default_recv_buf_type = decltype(kamping::recv_buf(alloc_new<DefaultContainerType<send_value_type>>));
auto&& recv_buf =
auto recv_buf =
internal::select_parameter_type_or_default<internal::ParameterType::recv_buf, default_recv_buf_type>(
std::tuple(),
args...
Expand All @@ -347,14 +347,14 @@ auto kamping::Communicator<DefaultContainerType, Plugins...>::allgatherv(Args...
using recv_value_type = typename std::remove_reference_t<decltype(recv_buf)>::value_type;

// get send/recv types
auto&& [send_type, recv_type] =
auto [send_type, recv_type] =
internal::determine_mpi_datatypes<send_value_type, recv_value_type, decltype(recv_buf)>(args...);
[[maybe_unused]] constexpr bool send_type_is_input_parameter = !internal::has_to_be_computed<decltype(send_type)>;
[[maybe_unused]] constexpr bool recv_type_is_input_parameter = !internal::has_to_be_computed<decltype(recv_type)>;

// get the send counts
using default_send_count_type = decltype(kamping::send_count_out());
auto&& send_count =
auto send_count =
internal::select_parameter_type_or_default<internal::ParameterType::send_count, default_send_count_type>(
std::tuple(),
args...
Expand All @@ -366,7 +366,7 @@ auto kamping::Communicator<DefaultContainerType, Plugins...>::allgatherv(Args...
}
// get the recv counts
using default_recv_counts_type = decltype(kamping::recv_counts_out(alloc_new<DefaultContainerType<int>>));
auto&& recv_counts =
auto recv_counts =
internal::select_parameter_type_or_default<internal::ParameterType::recv_counts, default_recv_counts_type>(
std::tuple(),
args...
Expand Down Expand Up @@ -394,7 +394,7 @@ auto kamping::Communicator<DefaultContainerType, Plugins...>::allgatherv(Args...

// Get recv_displs
using default_recv_displs_type = decltype(kamping::recv_displs_out(alloc_new<DefaultContainerType<int>>));
auto&& recv_displs =
auto recv_displs =
internal::select_parameter_type_or_default<internal::ParameterType::recv_displs, default_recv_displs_type>(
std::tuple(),
args...
Expand Down
26 changes: 13 additions & 13 deletions include/kamping/collectives/allreduce.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,14 +85,14 @@ auto kamping::Communicator<DefaultContainerType, Plugins...>::allreduce(Args...
);

// Get the send buffer and deduce the send and recv value types.
auto const& send_buf = select_parameter_type<ParameterType::send_buf>(args...).construct_buffer_or_rebind();
auto const send_buf = select_parameter_type<ParameterType::send_buf>(args...).construct_buffer_or_rebind();
using send_value_type = typename std::remove_reference_t<decltype(send_buf)>::value_type;
using default_recv_value_type = std::remove_const_t<send_value_type>;

// Deduce the recv buffer type and get (if provided) the recv buffer or allocate one (if not provided).
using default_recv_buf_type =
decltype(kamping::recv_buf(alloc_new<DefaultContainerType<default_recv_value_type>>));
auto&& recv_buf =
auto recv_buf =
select_parameter_type_or_default<ParameterType::recv_buf, default_recv_buf_type>(std::tuple(), args...)
.template construct_buffer_or_rebind<DefaultContainerType>();
using recv_value_type = typename std::remove_reference_t<decltype(recv_buf)>::value_type;
Expand All @@ -102,18 +102,18 @@ auto kamping::Communicator<DefaultContainerType, Plugins...>::allreduce(Args...
);

// Get the send_recv_type.
auto&& send_recv_type = determine_mpi_send_recv_datatype<send_value_type, decltype(recv_buf)>(args...);
auto send_recv_type = determine_mpi_send_recv_datatype<send_value_type, decltype(recv_buf)>(args...);
[[maybe_unused]] constexpr bool send_recv_type_is_in_param = !has_to_be_computed<decltype(send_recv_type)>;

// Get the operation used for the reduction. The signature of the provided function is checked while building.
auto& operation_param = select_parameter_type<ParameterType::op>(args...);
auto operation = operation_param.template build_operation<send_value_type>();

using default_send_recv_count_type = decltype(kamping::send_recv_count_out());
auto&& send_recv_count = internal::select_parameter_type_or_default<
internal::ParameterType::send_recv_count,
default_send_recv_count_type>({}, args...)
.construct_buffer_or_rebind();
auto send_recv_count = internal::select_parameter_type_or_default<
internal::ParameterType::send_recv_count,
default_send_recv_count_type>({}, args...)
.construct_buffer_or_rebind();
if constexpr (has_to_be_computed<decltype(send_recv_count)>) {
send_recv_count.underlying() = asserting_cast<int>(send_buf.size());
}
Expand Down Expand Up @@ -201,22 +201,22 @@ auto kamping::Communicator<DefaultContainerType, Plugins...>::allreduce_inplace(
);

// Get the send buffer and deduce the send and recv value types.
auto&& send_recv_buf = select_parameter_type<ParameterType::send_recv_buf>(args...).construct_buffer_or_rebind();
auto send_recv_buf = select_parameter_type<ParameterType::send_recv_buf>(args...).construct_buffer_or_rebind();
using send_recv_value_type = typename std::remove_reference_t<decltype(send_recv_buf)>::value_type;

// Get the send_recv_type.
auto&& send_recv_type = determine_mpi_send_recv_datatype<send_recv_value_type, decltype(send_recv_buf)>(args...);
auto send_recv_type = determine_mpi_send_recv_datatype<send_recv_value_type, decltype(send_recv_buf)>(args...);
[[maybe_unused]] constexpr bool send_recv_type_is_in_param = !has_to_be_computed<decltype(send_recv_type)>;

// Get the operation used for the reduction. The signature of the provided function is checked while building.
auto& operation_param = select_parameter_type<ParameterType::op>(args...);
auto operation = operation_param.template build_operation<send_recv_value_type>();

using default_send_recv_count_type = decltype(kamping::send_recv_count_out());
auto&& send_recv_count = internal::select_parameter_type_or_default<
internal::ParameterType::send_recv_count,
default_send_recv_count_type>({}, args...)
.construct_buffer_or_rebind();
auto send_recv_count = internal::select_parameter_type_or_default<
internal::ParameterType::send_recv_count,
default_send_recv_count_type>({}, args...)
.construct_buffer_or_rebind();
if constexpr (has_to_be_computed<decltype(send_recv_count)>) {
send_recv_count.underlying() = asserting_cast<int>(send_recv_buf.size());
}
Expand Down
51 changes: 22 additions & 29 deletions include/kamping/collectives/alltoall.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,19 +23,12 @@

#include "kamping/assertion_levels.hpp"
#include "kamping/checking_casts.hpp"
#include "kamping/collectives/barrier.hpp"
#include "kamping/collectives/collectives_helpers.hpp"
#include "kamping/collectives/ibarrier.hpp"
#include "kamping/comm_helper/is_same_on_all_ranks.hpp"
#include "kamping/communicator.hpp"
#include "kamping/mpi_datatype.hpp"
#include "kamping/named_parameter_check.hpp"
#include "kamping/named_parameter_selection.hpp"
#include "kamping/named_parameters.hpp"
#include "kamping/p2p/iprobe.hpp"
#include "kamping/p2p/isend.hpp"
#include "kamping/p2p/recv.hpp"
#include "kamping/request_pool.hpp"
#include "kamping/result.hpp"

/// @addtogroup kamping_collectives
Expand All @@ -46,8 +39,8 @@
/// This wrapper for \c MPI_Alltoall sends the same amount of data from each rank to each rank. The following
/// buffers are required:
/// - \ref kamping::send_buf() containing the data that is sent to each rank. This buffer has to be the same size at
/// each rank and divisible by the size of the communicator unless a send_count or a send_type is explicitly given as
/// parameter. Each rank receives the same number of elements from this buffer.
/// each rank and divisible by the size of the communicator unless a send_count or a send_type is explicitly given
/// as parameter. Each rank receives the same number of elements from this buffer.
///
/// The following parameters are optional:
/// - \ref kamping::send_count() specifying how many elements are sent. If
Expand All @@ -61,11 +54,11 @@
/// - \ref kamping::recv_buf() specifying a buffer for the output. A buffer of at least
/// `recv_count * communicator size` is required.
///
/// - \ref kamping::send_type() specifying the \c MPI datatype to use as send type. If omitted, the \c MPI datatype is
/// derived automatically based on send_buf's underlying \c value_type.
/// - \ref kamping::send_type() specifying the \c MPI datatype to use as send type. If omitted, the \c MPI datatype
/// is derived automatically based on send_buf's underlying \c value_type.
///
/// - \ref kamping::recv_type() specifying the \c MPI datatype to use as recv type. If omitted, the \c MPI datatype is
/// derived automatically based on recv_buf's underlying \c value_type.
/// - \ref kamping::recv_type() specifying the \c MPI datatype to use as recv type. If omitted, the \c MPI datatype
/// is derived automatically based on recv_buf's underlying \c value_type.
///
/// Inplace alltoall is supported by passing send_recv_buf as parameter. This changes the requirements for the other
/// parameters, see \ref Communicator::alltoall_inplace.
Expand Down Expand Up @@ -96,14 +89,14 @@ auto kamping::Communicator<DefaultContainerType, Plugins...>::alltoall(Args... a
);

// Get the buffers
auto const&& send_buf =
auto const send_buf =
internal::select_parameter_type<internal::ParameterType::send_buf>(args...).construct_buffer_or_rebind();
using send_value_type = typename std::remove_reference_t<decltype(send_buf)>::value_type;
using default_recv_value_type = std::remove_const_t<send_value_type>;

using default_recv_buf_type =
decltype(kamping::recv_buf(alloc_new<DefaultContainerType<default_recv_value_type>>));
auto&& recv_buf =
auto recv_buf =
internal::select_parameter_type_or_default<internal::ParameterType::recv_buf, default_recv_buf_type>(
std::tuple(),
args...
Expand All @@ -113,13 +106,13 @@ auto kamping::Communicator<DefaultContainerType, Plugins...>::alltoall(Args... a

static_assert(!std::is_const_v<recv_value_type>, "The receive buffer must not have a const value_type.");

auto&& [send_type, recv_type] =
auto [send_type, recv_type] =
internal::determine_mpi_datatypes<send_value_type, recv_value_type, decltype(recv_buf)>(args...);
[[maybe_unused]] constexpr bool recv_type_has_to_be_deduced = has_to_be_computed<decltype(recv_type)>;

// Get the send counts
using default_send_count_type = decltype(kamping::send_count_out());
auto&& send_count =
auto send_count =
internal::select_parameter_type_or_default<internal::ParameterType::send_count, default_send_count_type>(
std::tuple(),
args...
Expand All @@ -131,7 +124,7 @@ auto kamping::Communicator<DefaultContainerType, Plugins...>::alltoall(Args... a
}
// Get the recv counts
using default_recv_count_type = decltype(kamping::recv_count_out());
auto&& recv_count =
auto recv_count =
internal::select_parameter_type_or_default<internal::ParameterType::recv_count, default_recv_count_type>(
std::tuple(),
args...
Expand Down Expand Up @@ -230,20 +223,20 @@ auto kamping::Communicator<DefaultContainerType, Plugins...>::alltoall_inplace(A
KAMPING_OPTIONAL_PARAMETERS(send_recv_count, send_recv_type)
);

auto&& send_recv_buf =
auto send_recv_buf =
internal::select_parameter_type<internal::ParameterType::send_recv_buf>(args...).construct_buffer_or_rebind();
using send_recv_value_type = typename std::remove_reference_t<decltype(send_recv_buf)>::value_type;
auto&& send_recv_type =
auto send_recv_type =
internal::determine_mpi_send_recv_datatype<send_recv_value_type, decltype(send_recv_buf)>(args...);
[[maybe_unused]] constexpr bool send_recv_type_has_to_be_deduced = has_to_be_computed<decltype(send_recv_type)>;

// Get the optional recv_count parameter. If the parameter is not given, allocate a new container.
using default_count_type = decltype(kamping::send_recv_count_out());
auto&& count_param = internal::select_parameter_type_or_default<ParameterType::send_recv_count, default_count_type>(
std::tuple(),
args...
auto count_param = internal::select_parameter_type_or_default<ParameterType::send_recv_count, default_count_type>(
std::tuple(),
args...
)
.construct_buffer_or_rebind();
.construct_buffer_or_rebind();
constexpr bool count_has_to_be_computed = has_to_be_computed<decltype(count_param)>;

KASSERT(
Expand Down Expand Up @@ -348,7 +341,7 @@ auto kamping::Communicator<DefaultContainerType, Plugins...>::alltoallv(Args...

// Get recv_buf
using default_recv_buf_type = decltype(kamping::recv_buf(alloc_new<DefaultContainerType<default_recv_value_type>>));
auto&& recv_buf =
auto recv_buf =
internal::select_parameter_type_or_default<internal::ParameterType::recv_buf, default_recv_buf_type>(
std::tuple(),
args...
Expand All @@ -357,7 +350,7 @@ auto kamping::Communicator<DefaultContainerType, Plugins...>::alltoallv(Args...
using recv_value_type = typename std::remove_reference_t<decltype(recv_buf)>::value_type;

// Get send/recv types
auto&& [send_type, recv_type] =
auto [send_type, recv_type] =
internal::determine_mpi_datatypes<send_value_type, recv_value_type, decltype(recv_buf)>(args...);
[[maybe_unused]] constexpr bool send_type_has_to_be_deduced = internal::has_to_be_computed<decltype(send_type)>;
[[maybe_unused]] constexpr bool recv_type_has_to_be_deduced = internal::has_to_be_computed<decltype(recv_type)>;
Expand All @@ -375,7 +368,7 @@ auto kamping::Communicator<DefaultContainerType, Plugins...>::alltoallv(Args...

// Get recv_counts
using default_recv_counts_type = decltype(kamping::recv_counts_out(alloc_new<DefaultContainerType<int>>));
auto&& recv_counts =
auto recv_counts =
internal::select_parameter_type_or_default<internal::ParameterType::recv_counts, default_recv_counts_type>(
std::tuple(),
args...
Expand All @@ -386,7 +379,7 @@ auto kamping::Communicator<DefaultContainerType, Plugins...>::alltoallv(Args...

// Get send_displs
using default_send_displs_type = decltype(kamping::send_displs_out(alloc_new<DefaultContainerType<int>>));
auto&& send_displs =
auto send_displs =
internal::select_parameter_type_or_default<internal::ParameterType::send_displs, default_send_displs_type>(
std::tuple(),
args...
Expand All @@ -397,7 +390,7 @@ auto kamping::Communicator<DefaultContainerType, Plugins...>::alltoallv(Args...

// Get recv_displs
using default_recv_displs_type = decltype(kamping::recv_displs_out(alloc_new<DefaultContainerType<int>>));
auto&& recv_displs =
auto recv_displs =
internal::select_parameter_type_or_default<internal::ParameterType::recv_displs, default_recv_displs_type>(
std::tuple(),
args...
Expand Down
Loading
Loading