my.core.logging: compatibility with HPI_LOGS #307
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had tried to set the
DEFAULT_LEVEL
like we discussed in #305 here:HPI/my/core/logging.py
Line 49 in c283e54
But if the module had already set a level like:
then any attempt to use
HPI_LOGS
(which would use theDEFAULT_LEVEL
) would be ignored, which is not what the user would expect (they'd expect the--debug
flag to just override everything)So, added a check after the
LOGGING_LEVEL_
check in theget_env_level
function instead