Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: v0.3.7 does not work in ie8 fix #105 #106

Merged
merged 1 commit into from
Mar 16, 2016
Merged

fix: v0.3.7 does not work in ie8 fix #105 #106

merged 1 commit into from
Mar 16, 2016

Conversation

maksimr
Copy link
Contributor

@maksimr maksimr commented Feb 23, 2016

No description provided.

@maksimr
Copy link
Contributor Author

maksimr commented Mar 14, 2016

@dignifiedquire what do you think about these changes?

@dignifiedquire
Copy link
Member

I'm not sure this is a good idea, if we shim globals and people start relying on them in their tests, things will suddenly fail in production. Maybe we just add a comment in the notes that for these browsers you should include an appropriate es5 shim? Or am I missing sth? Also if we pull this in I'd rather use a shim library rather than duplicating these here.

@maksimr
Copy link
Contributor Author

maksimr commented Mar 14, 2016

@dignifiedquire yeh,

I taught about this but I decided to make fix because jasmine-core support IE8 and usage of filter and map in our code it's our problem and to force people use es5 shim only because karma-jasmine adapter use it's a "so so" solution.

@dignifiedquire
Copy link
Member

How about we use the lodash methods instead? that way we do not do any polyfilling and we have explicit dependencies

@maksimr
Copy link
Contributor Author

maksimr commented Mar 14, 2016

Do you want to load lodash here?

@dignifiedquire
Copy link
Member

Nvm, I'm too tired to say anything useful...

@maksimr
Copy link
Contributor Author

maksimr commented Mar 14, 2016

@dignifiedquire ok :)

@dignifiedquire
Copy link
Member

Merging this for now as I don't have a better solution, thanks @maksimr

dignifiedquire added a commit that referenced this pull request Mar 16, 2016
fix: v0.3.7 does not work in ie8 fix #105
@dignifiedquire dignifiedquire merged commit abc3f65 into karma-runner:master Mar 16, 2016
@maksimr
Copy link
Contributor Author

maksimr commented Mar 16, 2016

@dignifiedquire no problem!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants