-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
fix: v0.3.7 does not work in ie8 fix #105 #106
Conversation
@dignifiedquire what do you think about these changes? |
I'm not sure this is a good idea, if we shim globals and people start relying on them in their tests, things will suddenly fail in production. Maybe we just add a comment in the notes that for these browsers you should include an appropriate es5 shim? Or am I missing sth? Also if we pull this in I'd rather use a shim library rather than duplicating these here. |
@dignifiedquire yeh, I taught about this but I decided to make fix because jasmine-core support IE8 and usage of filter and map in our code it's our problem and to force people use es5 shim only because karma-jasmine adapter use it's a "so so" solution. |
How about we use the lodash methods instead? that way we do not do any polyfilling and we have explicit dependencies |
Do you want to load |
Nvm, I'm too tired to say anything useful... |
@dignifiedquire ok :) |
Merging this for now as I don't have a better solution, thanks @maksimr |
fix: v0.3.7 does not work in ie8 fix #105
@dignifiedquire no problem! |
No description provided.