-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Update node version #165
base: master
Are you sure you want to change the base?
Update node version #165
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
CLAs look good, thanks! |
I think putting each of these in a separate PR will make maintenance easier. We typically merge all the commits in a PR. If any one of these needs to be reverted we'll have to revert them all. That said I'll leave it to joeyparrish to decide. It does not look like Travis is connected for this repo. |
As @johnjbarton suggested I've divided this in separate PRs
|
[1] libxml-xsd is obsolete and it doesn't support nodejs 10 in the other hand, libxmljs can be used to check xsd schemas.