remove mockResourceDetector

[zach593]

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

mockResourceDetector isn't working and we don't need it to complete the tests.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.11%. Comparing base (2be7042) to head (33a9490).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #6106   +/-   ##
=======================================
  Coverage   48.11%   48.11%           
=======================================
  Files         668      668           
  Lines       55238    55238           
=======================================
  Hits        26579    26579           
  Misses      26928    26928           
  Partials     1731     1731           

Flag	Coverage Δ
unittests	48.11% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[RainbowMango]

/assign @XiShanYongYe-Chang

[XiShanYongYe-Chang]

The mockResourceDetector is invalid due to the change of the detector BuildResourceBinding and BuildClusterResourceBinding methods. In addition, the test content shows that the mockResourceDetector is normal if the detector is not mocked.

Thanks~
/lgtm
/approve

[karmada-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: XiShanYongYe-Chang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [XiShanYongYe-Chang]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[zach593]

I'm not sure if we are talking about the same thing. After testing, these mock methods are not called at all, which is why it still could compile when the function signature is changed.

As for why the mock does not take effect, it is because in the tests, (d *ResourceDetector) ApplyPolicy() and (d *ResourceDetector) ApplyClusterPolicy() are called.
Therefore, when they're calling the methods that "we think are mocked" like d.ClaimClusterPolicyForObject() in these two functions, the receivers d are also *ResourceDetector, so the mock functions have no chance to be called at all.

@XiShanYongYe-Chang

[XiShanYongYe-Chang]

Thanks @zach593
The mockResourceDetector has not taken effect since it was added, do you mean that?

[zach593]

The mockResourceDetector has not taken effect since it was added, do you mean that?

Yes, it is. 😄