Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Bug] Warning about google colab runtime could be a tad more helpful/precise (base_64) #37

Closed
davidefiocco opened this issue Jan 31, 2022 · 1 comment · Fixed by #38
Closed
Assignees
Labels
bug Something isn't working documentation Improvements or additions to documentation

Comments

@davidefiocco
Copy link
Contributor

davidefiocco commented Jan 31, 2022

Hi!

I think that in

If images are not displaying properly please try setting `base_64` param to `True`.
the warning should refer to force_b64 (not base_64) to fix problems that may occur in Google colab.

davidefiocco added a commit to davidefiocco/ipyplot that referenced this issue Jan 31, 2022
@karolzak karolzak linked a pull request Jan 31, 2022 that will close this issue
karolzak pushed a commit that referenced this issue Jan 31, 2022
@karolzak karolzak changed the title Warning about colab runtime could be a tad more helpful/precise (base_64) [Bug] Warning about google collab runtime could be a tad more helpful/precise (base_64) Jan 31, 2022
@karolzak karolzak self-assigned this Jan 31, 2022
@karolzak karolzak added bug Something isn't working documentation Improvements or additions to documentation labels Jan 31, 2022
@karolzak
Copy link
Owner

Good catch @davidefiocco, thanks for fixing it!

@davidefiocco davidefiocco changed the title [Bug] Warning about google collab runtime could be a tad more helpful/precise (base_64) [Bug] Warning about google colab runtime could be a tad more helpful/precise (base_64) Jan 31, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants