Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Docs] add back examples that can be copy/pasted in readme #40

Closed
rom1504 opened this issue Mar 13, 2022 · 1 comment · Fixed by #41
Closed

[Docs] add back examples that can be copy/pasted in readme #40

rom1504 opened this issue Mar 13, 2022 · 1 comment · Fixed by #41
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@rom1504
Copy link

rom1504 commented Mar 13, 2022

screenshots are nice but not convenient

@karolzak
Copy link
Owner

Thanks for your feedback @rom1504 !
I showcased all the code examples in this notebook but I totally see how it would be useful to have at least some base examples directly in readme - I'll make sure to add it, thanks!

@karolzak karolzak self-assigned this Mar 14, 2022
@karolzak karolzak added the documentation Improvements or additions to documentation label Mar 14, 2022
@karolzak karolzak changed the title add back examples that can be copy/pasted in readme [Docs] add back examples that can be copy/pasted in readme Mar 14, 2022
karolzak added a commit that referenced this issue Mar 14, 2022
@karolzak karolzak linked a pull request Mar 14, 2022 that will close this issue
karolzak added a commit that referenced this issue Mar 15, 2022
* fix #17 convert url to rel path

* upd disallow passing None to img_width

* fix #39

* upd readme #40

* fix #36 don't rescale images by default
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants