Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

More correct validation of previewContentTemplates #1276

Closed
wants to merge 2 commits into from

Conversation

alexandernarozhnov
Copy link

@alexandernarozhnov alexandernarozhnov commented Jul 23, 2018

Scope

This pull request includes a

  • Bug fix
  • New feature
  • Translation

Changes

This changes will allow you to configure preview templates. On small screens, for example on Safari in IPhone 5SE, fileinput has problems with showing of pdf-files previews. These previews are located on embed-container. This problems disappear after transfering from embed to iframe. That's why i thought that flexibility of this option is necessary.

Related Issues

If this is related to an existing ticket, include a link to it as well.

@kartik-v
Copy link
Owner

kartik-v commented Jul 25, 2018

Related to enhancement #1254. Will update over this.

@kartik-v kartik-v changed the title Added ability to change templates for file previews. This issue can h… Allow configuration of previewContentTemplates Jul 25, 2018
@kartik-v kartik-v changed the title Allow configuration of previewContentTemplates Use previewContentTemplates to init templates instead of internal defaults Jul 25, 2018
@kartik-v kartik-v changed the title Use previewContentTemplates to init templates instead of internal defaults More correct validation of previewContentTemplates Jul 25, 2018
@kartik-v kartik-v added the bug label Jul 25, 2018
@kartik-v kartik-v closed this in 5c2f7f1 Jul 25, 2018
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants