Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

VMT: add KCSAs for CVE-2020-2024 and CVE-2020-2025 #156

Merged
merged 1 commit into from
Jun 3, 2020

Conversation

bergwolf
Copy link
Member

We have fixed them and put the fix in a release. Let's
make the announcement.

/cc @yuvalavra

issues:

links:
- https://github.com/kata-containers/runtime/issues/2488
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this URL correct?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This probably needs to be kata-containers/runtime#2487 instead @bergwolf

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR link is below in reviews section. This one is the issue link, although it doesn't talk much about the vulnerability.

Copy link

@devimc devimc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @bergwolf

nit: 80 character per line

CI is not happy

ERROR: Document VMT/KCSA/KCSA-CVE-2020-2024.md is not referenced

@grahamwhaley
Copy link
Contributor

thanks @bergwolf

nit: 80 character per line

CI is not happy

ERROR: Document VMT/KCSA/KCSA-CVE-2020-2024.md is not referenced

You need to index them into this table @bergwolf :-)

- View the guest rootfs image on the host and the file can be seen there

notes:
- The vulnerability can be used to attack other guests by malicious containers that find other ways to gain control over the guest. And all users running Kata Containers on top of Cloud Hypervisor are recomended to upgrade.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/recomended/recommended/

@bergwolf
Copy link
Member Author

updated. PTAL @amshinde @jodh-intel @devimc @grahamwhaley

Copy link

@devimc devimc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @bergwolf

Copy link
Contributor

@jodh-intel jodh-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bergwolf.

lgtm

When running Kata Containers with Cloud Hypervisor, any change made to root
filesystem device is written to the underlying .img file. Since the device
is plugged as read-write, a malicious guest could write to it through
utilities like debugfs.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is a mistake from my original advisory - debugfs isn't needed if the guest is malicious, the guest can simply create/modify files and the changes will propogate to the image file on the host.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yuvalavra malicious guest is a container that found a way to escape from the namespaces in the guest?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's how I refer to a guest running malicious code outside the container scope, but perhaps that's not Kata's terminology. It's not necessarily a container that escaped, for example CVE-2020-2025 would result in subsequent guests being malicious without their containers escaping.

My point here is to separate distinct issues: CVE-2020-2025 is exploitable from outside the container, if the container has a way to access the guest - that's a different issue.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point! I've re-phrased it and dropped debugfs.

reporters:

- name: Yuval Avrahami
affiliation: Yuval Avrahami
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @yuvalavra, which affiliation would you like to be linked to? Generally it can be a company or organization.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Palo Alto Networks, thanks

@bergwolf bergwolf force-pushed the vmt branch 2 times, most recently from 1fc61c0 to b6de971 Compare June 3, 2020 06:44
We have fixed them and put the fix in a release. Let's
make the announcement.

Fixes: kata-containers#155
Signed-off-by: Peng Tao <bergwolf@hyper.sh>
@jodh-intel
Copy link
Contributor

@yuvalavra - would you like to do a final check before this is merged?

Copy link

@yuvalavra yuvalavra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jodh-intel
Copy link
Contributor

Thanks @yuvalavra.

@jodh-intel jodh-intel merged commit a4ca525 into kata-containers:master Jun 3, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants