-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
VMT: add KCSAs for CVE-2020-2024 and CVE-2020-2025 #156
Conversation
issues: | ||
|
||
links: | ||
- https://github.com/kata-containers/runtime/issues/2488 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this URL correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This probably needs to be kata-containers/runtime#2487 instead @bergwolf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR link is below in reviews section. This one is the issue link, although it doesn't talk much about the vulnerability.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @bergwolf
nit: 80 character per line
CI is not happy
ERROR: Document VMT/KCSA/KCSA-CVE-2020-2024.md is not referenced
You need to index them into this table @bergwolf :-) |
VMT/KCSA/KCSA-CVE-2020-2025.md
Outdated
- View the guest rootfs image on the host and the file can be seen there | ||
|
||
notes: | ||
- The vulnerability can be used to attack other guests by malicious containers that find other ways to gain control over the guest. And all users running Kata Containers on top of Cloud Hypervisor are recomended to upgrade. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/recomended/recommended/
updated. PTAL @amshinde @jodh-intel @devimc @grahamwhaley |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @bergwolf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @bergwolf.
lgtm
VMT/KCSA/KCSA-CVE-2020-2025.md
Outdated
When running Kata Containers with Cloud Hypervisor, any change made to root | ||
filesystem device is written to the underlying .img file. Since the device | ||
is plugged as read-write, a malicious guest could write to it through | ||
utilities like debugfs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this is a mistake from my original advisory - debugfs
isn't needed if the guest is malicious, the guest can simply create/modify files and the changes will propogate to the image file on the host.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yuvalavra malicious guest
is a container that found a way to escape from the namespaces in the guest?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's how I refer to a guest running malicious code outside the container scope, but perhaps that's not Kata's terminology. It's not necessarily a container that escaped, for example CVE-2020-2025
would result in subsequent guests being malicious without their containers escaping.
My point here is to separate distinct issues: CVE-2020-2025
is exploitable from outside the container, if the container has a way to access the guest - that's a different issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point! I've re-phrased it and dropped debugfs
.
VMT/KCSA/KCSA-CVE-2020-2024.md
Outdated
reporters: | ||
|
||
- name: Yuval Avrahami | ||
affiliation: Yuval Avrahami |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi @yuvalavra, which affiliation would you like to be linked to? Generally it can be a company or organization.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Palo Alto Networks, thanks
1fc61c0
to
b6de971
Compare
We have fixed them and put the fix in a release. Let's make the announcement. Fixes: kata-containers#155 Signed-off-by: Peng Tao <bergwolf@hyper.sh>
@yuvalavra - would you like to do a final check before this is merged? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @yuvalavra. |
We have fixed them and put the fix in a release. Let's
make the announcement.
/cc @yuvalavra