Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

CI: Fire a test PR for the jenkins CI (Do not merge) #140

Closed
wants to merge 1 commit into from
Closed

CI: Fire a test PR for the jenkins CI (Do not merge) #140

wants to merge 1 commit into from

Conversation

nitkon
Copy link
Contributor

@nitkon nitkon commented Jan 25, 2019

Make a minor readme change to fire a test
PR for IBM Power Jenkins CI.

Fixes #57

Signed-off-by: Nitesh Konkar niteshkonkar@in.ibm.com

Fire a test PR for IBM Power Jenkins CI

Fixes #57

Signed-off-by: Nitesh Konkar <niteshkonkar@in.ibm.com>
@nitkon nitkon requested a review from a team as a code owner January 25, 2019 16:02
@nitkon
Copy link
Contributor Author

nitkon commented Jan 25, 2019

/test

@grahamwhaley
Copy link
Contributor

Hey, @nitkon - presuming you didn't add the documentation team as a specific review group to this PR, then this is great - github used the recently merged CODEOWNERS file to auto-request the docs team it loks ;-)
/cc @ttx @fungi

@opendev-zuul
Copy link

opendev-zuul bot commented Jan 25, 2019

Build failed (third-party-check pipeline) integration testing with
OpenStack. For information on how to proceed, see
http://docs.openstack.org/infra/manual/developers.html#automated-testing

@nitkon
Copy link
Contributor Author

nitkon commented Jan 27, 2019

@jodh-intel : Yup. I did not add any review group. I have raised another PR as I deleted the fork from which I had submitted this PR.

@nitkon nitkon closed this Jan 27, 2019
@grahamwhaley
Copy link
Contributor

@nitkon - I'm confused - why did you close this and delete the branch?
If it was because a review group got automatically added - that is meant to happen - it is part of our 'replace pullapprove' strategy. You modified a document, so the document reviewers automatically got added as a 'required to review' group :-)

@nitkon
Copy link
Contributor Author

nitkon commented Jan 28, 2019

@grahamwhaley: Actually I deleted my branch by mistake & that's why I had to close this PR.

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants