Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

containerd-shim-v2: Wait() should support multiple callers #1131

Closed
sboeuf opened this issue Jan 15, 2019 · 2 comments
Closed

containerd-shim-v2: Wait() should support multiple callers #1131

sboeuf opened this issue Jan 15, 2019 · 2 comments
Assignees
@lifupan

Comments

@sboeuf
Copy link

sboeuf commented Jan 15, 2019

I don't think the containerd-shim-v2 API specifies that we should only support one single call of the Wait() function. Instead, it'd feel more natural to be able to have several callers being able to invoke Wait() and to get the exit code when the process returns.
@sboeuf
Copy link
Author

sboeuf commented Jan 15, 2019

/cc @lifupan

lifupan added a commit to lifupan/kata-runtime that referenced this issue Jan 16, 2019
@lifupan
shimv2: multi wait support for wait service
e71f082 
Support multi wait on one container/exec process.

Fixes: kata-containers#1131

Signed-off-by: fupan <lifupan@gmail.com>
@lifupan lifupan mentioned this issue Jan 16, 2019
Merged
@lifupan
Copy link
Member

lifupan commented Jan 16, 2019

@sboeuf Thanks for raising this issue, I had send a PR #1133 to address it.

lifupan added a commit to lifupan/kata-runtime that referenced this issue Jan 16, 2019
@lifupan
shimv2: multi wait support for wait service
5ba30fd 
Support multi wait on one container/exec process.

Fixes: kata-containers#1131

Signed-off-by: fupan <lifupan@gmail.com>
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Assignees

@lifupan lifupan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lifupan @sboeuf