This repository has been archived by the owner on May 12, 2021. It is now read-only.
govmmQemu.LaunchQemu() would get error of "waitid: no child processes" for shimv2 #939
Comments
lifupan
added a commit
to lifupan/kata-runtime
that referenced
this issue
Nov 24, 2018
When govmmQemu.LaunchQemu() launching a qemu process using os/exec.Cmd.Run(), its child qemu process would be reaped by other reapers, in this case Cmd.Wait() will get an error of "waitid: no child processes", thus it's better to ignore this error since it has launch qemu successfully. Fixes: kata-containers#939 Signed-off-by: fupan <lifupan@gmail.com>
lifupan
added a commit
to lifupan/kata-runtime
that referenced
this issue
Nov 27, 2018
When govmmQemu.LaunchQemu() launching a qemu process using os/exec.Cmd.Run(), its child qemu process would be reaped by other reapers, in this case Cmd.Wait() will get an error of "waitid: no child processes", thus it's better to ignore this error since it has launch qemu successfully. Fixes: kata-containers#939 Signed-off-by: fupan <lifupan@gmail.com>
lifupan
added a commit
to hyperhq/kata-runtime
that referenced
this issue
Nov 28, 2018
When govmmQemu.LaunchQemu() launching a qemu process using os/exec.Cmd.Run(), its child qemu process would be reaped by other reapers, in this case Cmd.Wait() will get an error of "waitid: no child processes", thus it's better to ignore this error since it has launch qemu successfully. Fixes: kata-containers#939 Signed-off-by: fupan <lifupan@gmail.com>
lifupan
added a commit
to lifupan/kata-runtime
that referenced
this issue
Dec 3, 2018
For kata shimv2, it doesn't need to reap it's container processes since all of them are running in VM, thus there is no need to set it as a subreaper and also no need to take care of the SIGCHLD singal. So this commit will try to unset the subreaper and ignore the SIGCHLD signal. Since ignoring the SIGCHLD signal will break the containerd shim's events.Publisher publish method, thus here re-write a publish function to publish the events to containerd. Fixes: kata-containers#939 Signed-off-by: fupan <lifupan@gmail.com>
lifupan
added a commit
to lifupan/kata-runtime
that referenced
this issue
Dec 6, 2018
For kata shimv2, the sub-reaper isn't needed, otherwise it will break the cmd.Run() calling in govmmQemu.LaunchQemu(). Fixes: kata-containers#939 Signed-off-by: fupan <lifupan@gmail.com>
lifupan
added a commit
to lifupan/kata-runtime
that referenced
this issue
Dec 10, 2018
For kata shimv2, the sub-reaper isn't needed, otherwise it will break the cmd.Run() calling in govmmQemu.LaunchQemu(). Fixes: kata-containers#939 Signed-off-by: fupan <lifupan@gmail.com>
lifupan
added a commit
to lifupan/kata-runtime
that referenced
this issue
Dec 11, 2018
For kata shimv2, the sub-reaper isn't needed, otherwise it will break the cmd.Run() calling in govmmQemu.LaunchQemu(). Fixes: kata-containers#939 Signed-off-by: fupan <lifupan@gmail.com>
lifupan
added a commit
to lifupan/kata-runtime
that referenced
this issue
Dec 11, 2018
For kata shimv2, the sub-reaper isn't needed, otherwise it will break the cmd.Run() calling in govmmQemu.LaunchQemu(). Fixes: kata-containers#939 Signed-off-by: fupan <lifupan@gmail.com>
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Description of problem
containerd-shimv2 will have its own children reapers which would reap the
qemu's process before LaunchQemu's cmd.Run to reap it. For this case, the govmmQemu.LaunchQemu() will get an error contains substring of "no child processes", thus it's needed to ignore this error and deal it as success.
Expected result
(replace this text with an explanation of what you thought would happen)
Actual result
(replace this text with details of what actually happened)
(replace this text with the output of the
kata-collect-data.shscript, afteryou have reviewed its content to ensure it does not contain any private
information).
The text was updated successfully, but these errors were encountered: