-
Notifications
You must be signed in to change notification settings - Fork 373
vendor: introduce libcontainer/cgroups package #405
vendor: introduce libcontainer/cgroups package #405
Conversation
Introduce libcontainer/cgroups package for further cgroups handling refactor Fixes: #344 Signed-off-by: Jingxiao Lu <lujingxiao@huawei.com>
PSS Measurement: Memory inside container: |
This is the first PR for #344, introducing Please share your comments on this issue 😄 Other PRs will come on including:
|
@sboeuf @jodh-intel @grahamwhaley PTAL cc\ @WeiZhang555 |
Hi @jingxiaolu - thanks for raising. lgtm. |
@jodh-intel CI failure looks same as kata-containers/tests#427 (see #385 (comment)) . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jingxiaolu I dont see any changes to the Gopkg.toml file here.
@amshinde - I noticed that too. I believe that's because no change is necessary to |
@jodh-intel You are right. Missed out on the previous opencontainers package. |
@jingxiaolu Can you rebase your changes on top of the latest master? CI failures have been fixed on master. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jingxiaolu sorry but we cannot accept this PR as is. The vendoring diff that you're introducing here depends on the fact that you've added an import into the code, meaning that a dep update
gave you such a diff.
So basically, you will have to submit this change through the PR introducing the change in the code where you import the new package.
@sboeuf that's reasonable, I'll resubmit with more implementation~ @jshachm @jodh-intel @devimc @amshinde thanks for your time 👍 |
Introduce libcontainer/cgroups package for further cgroups handling refactor
Fixes: #344
Signed-off-by: Jingxiao Lu lujingxiao@huawei.com