This repository has been archived by the owner on Jun 28, 2024. It is now read-only.
[DNM]: test commit for docker connect #743
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bergwolf
force-pushed
the
test-netmon
branch
from
eefdd7d to
61d2221
Compare
bergwolf
changed the title
bergwolf
force-pushed
the
test-netmon
branch
2 times, most recently
from
31d98f7 to
5fe7e00
Compare
|
I've triggered tests for this for three times, once passed and twice failed on getting the IP of the added nic. Still not sure what makes the difference. Seems like CI successfully simulated both @sboeuf's case and mine. @sboeuf @devimc @amshinde any ideas? This basically tests network hotplug using the netmon PR. |
Let's see what we can get in CI environment. Please DO NOT MERGE! Fixes: #999999999 Signed-off-by: Peng Tao <bergwolf@gmail.com>
bergwolf
force-pushed
the
test-netmon
branch
from
5fe7e00 to
d408d2f
Compare
|
@bergwolf Can this be closed? |
|
yup @caoruidong |
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@sboeuf and I were getting different results w.r.t. network hotplug functionality. Still not sure what makes the difference. Let's see what we can get in CI environment. So we can have a base line for environment comparison.
Please DO NOT MERGE!