Waveform with rounded bars #1760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thijstriemstra
suggested changes
Oct 5, 2019
There was a problem hiding this comment.
thanks @kubk. Can you call the new method drawRoundedRect so it matches the other method names (e.g. fillRect)?
thijstriemstra
changed the title
|
@thijstriemstra Thank you! 👍 |
thanks @kubk, looking forward to that PR as well |
thijstriemstra
approved these changes
Oct 6, 2019
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of changes:
Added an optional
barRadiusparameter for specifying the radius of rounded bars. AddeddrawRoundedRectmethod for rendering rounded bars on Canvas.Breaking in the external API:
No BC break.
Breaking changes in the internal API:
No BC break.
Related Issues and other PRs:
fixes #953
Notes
If this will be merged I will document this feature in
gh-pagesbranchExample