Use rustup for better versioning #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lteacher
commented
Jul 15, 2017
| # Setup env | ||
| ENV USER codewarrior | ||
| ENV HOME /home/codewarrior | ||
| ENV NPM_CONFIG_LOGLEVEL warn | ||
| ENV PATH $HOME/.cargo/bin:$PATH |
There was a problem hiding this comment.
This path has the versioned rustc, without setting it here, the mocha tests won't find rustc later in the dockerfile
| # Setup env | ||
| ENV USER codewarrior | ||
| ENV HOME /home/codewarrior | ||
| ENV NPM_CONFIG_LOGLEVEL warn | ||
| ENV PATH $HOME/.cargo/bin:$PATH | ||
|
|
||
| # Install rustup with the Rust v1.15.1 toolchain |
There was a problem hiding this comment.
The block was moved below because the install script needs to create the local .cargo directory for example but when it was up top the environments were not set to do it perfectly as they reference $HOME in the shell script.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per comment on codewars#464 this change would instead use
rustupto manage the versioning.Probably would be further changes later for codewars#240 to initialise the cargo project to change from using the
main.rsfile created now to using a cargo folder structure which would have the neededCargo.tomlfor dependencies.