Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Array.includes() breaks in IE 11 #851

Closed
Neunerlei opened this issue Apr 20, 2020 · 0 comments · Fixed by #857
Closed

Array.includes() breaks in IE 11 #851

Neunerlei opened this issue Apr 20, 2020 · 0 comments · Fixed by #857
Labels
good first issue Good for newcomers help wanted Extra attention is needed Status: PR Welcome Welcome to Pull Request Type: Bug Bug or Bug fixes

Comments

@Neunerlei
Copy link

vue & vue-i18n version

2.6.11 & 8.17.3

Reproduction Link

image

Steps to reproduce

It seems like the IE breaks in the latest Version when you try to translate a label,
because the code relies on .includes() on an array object.

After adding a Polyfill everything works as expected. :)
@kazupon kazupon added good first issue Good for newcomers help wanted Extra attention is needed Status: PR Welcome Welcome to Pull Request Type: Bug Bug or Bug fixes labels Apr 20, 2020
kazupon added a commit that referenced this issue Apr 25, 2020
@kazupon
fix: alternative array includes
e564190 
closes #851
@kazupon kazupon mentioned this issue Apr 25, 2020
Merged
kazupon added a commit that referenced this issue Apr 25, 2020
@kazupon
fix: alternative array includes (#857)
dea111b 
closes #851
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed Status: PR Welcome Welcome to Pull Request Type: Bug Bug or Bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: alternative array includes kazupon/vue-i18n
2 participants
@kazupon @Neunerlei