Fix callback logic attempt #2 #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The prior attempt polled the NERSC task CTS server side to wait for it to finish, which it never would since the task code was waiting for the request to return, which in turn was sitting there polling, so fun with deadlocks. Instead, use the result file written by the remote code to determine whether the data transfer is complete, which is now written out prior to the callback execution, so the task can still be running when the server decides to proceed with the data transfer completion routine.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #194 +/- ##
==========================================
+ Coverage 50.93% 51.02% +0.09%
==========================================
Files 37 37
Lines 2617 2626 +9
==========================================
+ Hits 1333 1340 +7
- Misses 1284 1286 +2 ☔ View full report in Codecov by Sentry. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The prior attempt polled the NERSC task CTS server side to wait for it to finish, which it never would since the task code was waiting for the request to return, which in turn was sitting there polling, so fun with deadlocks.
Instead, use the result file written by the remote code to determine whether the data transfer is complete, which is now written out prior to the callback execution, so the task can still be running when the server decides to proceed with the data transfer completion routine.