Skip to content

Commit

Permalink
Change postBuildExtras to use cordova provided list
Browse files Browse the repository at this point in the history
This fixes the problem where multiple cordova plugins attempting to use the postBuildExtras in the gradle script will simply clobber each other. The cordova provided gradle template provides a defined list for plugins to add their post build extras to so they can all play nicely together.

https://github.com/apache/cordova-android/blob/73edf4de7b751ecc103e9fad3c6d71c149c9118e/bin/templates/project/app/build.gradle#L90

This fixes the problems outlined in: 
meteor/meteor#7600
Meteor-Community-Packages/raix-push#334
  • Loading branch information
kcarwilemiller authored Oct 2, 2018
1 parent eb19701 commit ea6ad1f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/android/build-extras.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
specific language governing permissions and limitations
under the License.
*/
ext.postBuildExtras = {
ext.cdvPluginPostBuildExtras << {
def inAssetsDir = file("assets")
def outAssetsDir = inAssetsDir
def outFile = new File(outAssetsDir, "cdvasset.manifest")
Expand Down

0 comments on commit ea6ad1f

Please # to comment.