Skip to content

Feat(kclvm-win): rm py39-libs in kclvm-windows. #382

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Jan 16, 2023
Merged

Feat(kclvm-win): rm py39-libs in kclvm-windows. #382

merged 1 commit into from
Jan 16, 2023

Conversation

zong-zhe
Copy link
Contributor

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

issue #379

2. What is the scope of this PR (e.g. component or file name):

kclvm on windows.

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

rm py39-libs under scripts/build-windows/py-39-libs.
rm useless code in scripts/build-windows/build.bat.

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

rm py39-libs under scripts/build-windows/py-39-libs.
rm useless code in scripts/build-windows/build.bat.
issue #379.
@zong-zhe zong-zhe added the windows Only for windows. label Jan 16, 2023
@zong-zhe zong-zhe self-assigned this Jan 16, 2023
@coveralls
Copy link
Collaborator

coveralls commented Jan 16, 2023

Pull Request Test Coverage Report for Build 3927886658

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-29.0%) to 61.572%

Totals Coverage Status
Change from base Build 3909106975: -29.0%
Covered Lines: 21671
Relevant Lines: 35196

💛 - Coveralls

Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amyXia1994 amyXia1994 merged commit 9010e29 into kcl-lang:main Jan 16, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jan 16, 2023
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
windows Only for windows.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants