Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

✨ prow: use image ghcr.io/kcp-dev/infra/build:1.23.4-1 #82

Merged
merged 2 commits into from
Dec 23, 2024
Merged

✨ prow: use image ghcr.io/kcp-dev/infra/build:1.23.4-1 #82

merged 2 commits into from
Dec 23, 2024

Conversation

gman0
Copy link
Contributor

@gman0 gman0 commented Dec 18, 2024

Continuing with kcp-dev/infra#78, this PR uses the newer tag of the build image that contains go1.23 toolkit.

@kcp-ci-bot kcp-ci-bot added dco-signoff: no Indicates the PR's author has not signed the DCO. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 18, 2024
@kcp-ci-bot
Copy link
Contributor

Hi @gman0. Thanks for your PR.

I'm waiting for a kcp-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kcp-ci-bot kcp-ci-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 18, 2024
@gman0 gman0 changed the title Draft: ✨ prow: use image ghcr.io/kcp-dev/infra/build:1.23.4-1 ✨ prow: use image ghcr.io/kcp-dev/infra/build:1.23.4-1 Dec 20, 2024
@gman0
prow: use image ghcr.io/kcp-dev/infra/build:1.23.4-1
1b9876a 
On-behalf-of: SAP robert.vasek@sap.com
Signed-off-by: Robert Vasek <robert.vasek@clyso.com>
@gman0 gman0 force-pushed the prow-build-image-update branch from 14bbaca to 1b9876a Compare December 20, 2024 17:07
@kcp-ci-bot kcp-ci-bot added dco-signoff: yes Indicates the PR's author has signed the DCO. and removed dco-signoff: no Indicates the PR's author has not signed the DCO. labels Dec 20, 2024
@mjudeikis
Copy link
Contributor

/lgtm
/approve

@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 21, 2024
@kcp-ci-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: cb09b97128bb59d047064c9bc081c3d9e4bc0763

@gman0
Makefile: use golangci-lint v1.62.2
d207a2d 
golangci-lint is compatible up to the version of Go used to build it.
With moving to go1.23, we need to bump golangci-lint to support the
newer golang revision.

On-behalf-of: SAP robert.vasek@sap.com
Signed-off-by: Robert Vasek <robert.vasek@clyso.com>
@kcp-ci-bot kcp-ci-bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 23, 2024
@kcp-ci-bot kcp-ci-bot requested a review from mjudeikis December 23, 2024 10:42
@gman0
Copy link
Contributor Author

gman0 commented Dec 23, 2024 •
edited
Loading

golangci-lint is compatible up to the Go version used to compile it (reference: https://golangci-lint.run/product/changelog/#v1601 mentions added go1.23 support, and in general https://golangci-lint.run/welcome/faq/#which-go-versions-are-supported).

v1.58.1 we use is too old:

$ ./golangci-lint version
golangci-lint has version 1.58.1 built with go1.22.2 from dc281531 on 2024-05-08T18:53:57Z

The last commit I pushed bumps the linter to v1.62. Let me know if you prefer to do it in a separate PR.

@mjudeikis
Copy link
Contributor

/lgtm
/approve

@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 23, 2024
@kcp-ci-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d9be3fb6e4f32492dce1284e0db6d4515f133417

@mjudeikis
Copy link
Contributor

/approve
@sttts I think I dont have approval in here

@sttts
Copy link
Member

sttts commented Dec 23, 2024

/ok-to-test

@kcp-ci-bot kcp-ci-bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 23, 2024
@sttts
Copy link
Member

sttts commented Dec 23, 2024

/approve

@kcp-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mjudeikis, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 23, 2024
@kcp-ci-bot kcp-ci-bot merged commit b27d4eb into kcp-dev:main Dec 23, 2024
9 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@mjudeikis mjudeikis Awaiting requested review from mjudeikis

Assignees

@mjudeikis mjudeikis

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gman0 @kcp-ci-bot @mjudeikis @sttts