Undescore in base url is valid, use symfony url validator #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaljurecko
force-pushed
the
webrouse-COM-552-underscore-url
branch
from
63e0b70 to
31c8395
Compare
michaljurecko
force-pushed
the
webrouse-COM-552-underscore-url
branch
from
31c8395 to
a14c79a
Compare
michaljurecko
force-pushed
the
webrouse-COM-552-underscore-url
branch
from
0d2e965 to
0c5220e
Compare
michaljurecko
force-pushed
the
webrouse-COM-552-underscore-url
branch
from
0c5220e to
165010e
Compare
odinuv
approved these changes
Dec 1, 2020
| @@ -2,7 +2,7 @@ | |||
| "parameters": { | |||
| "api": { | |||
| "baseUrl": "https://mock-server-https-self-signed-proxy:443/141-https-self-signed/", | |||
| "caCertificate": "-----BEGIN CERTIFICATE-----\nMIIDNDCCAhwCCQCSteKUCHafQTANBgkqhkiG9w0BAQsFADBcMQswCQYDVQQGEwJV\nUzEPMA0GA1UECAwGRGVuaWFsMRQwEgYDVQQHDAtTcHJpbmdmaWVsZDEQMA4GA1UE\nCgwHRGlzUm9vdDEUMBIGA1UEAwwLQ29tcGFueVJvb3QwHhcNMjAwOTA3MTMzNDAy\nWhcNMjMwNjI4MTMzNDAyWjBcMQswCQYDVQQGEwJVUzEPMA0GA1UECAwGRGVuaWFs\nMRQwEgYDVQQHDAtTcHJpbmdmaWVsZDEQMA4GA1UECgwHRGlzUm9vdDEUMBIGA1UE\nAwwLQ29tcGFueVJvb3QwggEiMA0GCSqGSIb3DQEBAQUAA4IBDwAwggEKAoIBAQDQ\n5NSB5495dFt4X3TGrIV5iyqe//bHFOUcGM9eCL385csgskPFsX6HTHOMy4EhaNnD\nADy9xEJ9MMeeoN8y+K63LbHKvkaqH0O7AAF0WLtiBPozkta8InPa3qHyZKSHDlQT\niNKolFmWrAiGC25Wz95KNrX3XMwQKAHfclnsK0tKF4N0H4e4Eox81KNzUuNmfcJ0\n/WAF2XBldiaj8ggIJAK56pdHk3+RdV0MhLqVeCjzv216KyL/2upjAu0wbqLdfrHR\n9GjNBT/dIYGXXRZI6P4pivyTpTrovIGpO1gc0OVrfk569P5jo0ZH0M0l52m0QSXD\nvJteV6lf6OF2Dge6+ImdAgMBAAEwDQYJKoZIhvcNAQELBQADggEBAAnHmwrzodgS\n9rmjIZTuQdvKJcNGD7GZbxKtSOLwSe0G4/BDC+42TarYV6CBliOdMbLTflQmpYRJ\nfrQ94vtf4QoF0SvZnFs5EgO6152uii4W/1cgHbgX1zXOrQht9K64Nc4r7T0YEriE\n0mg14G9auB7kTrvSGRbMZ81QQ55tJCx0/7pg/9Xn+cLmjUpAnBlMgNgx/jMjYF1O\nFP01Z3rtCcO9hvVpWkp5duhmDWkS5fEoC2hklXRheH298SWPa/ld2ZT/Lyr5dhJ5\n7we+/PtzXBkwPdkrsVd4LNTVnmQTuvXIjDKxa0L4ZGHWNAI02yYwz5OfT64nsbAI\nFhUCy6kGY60=\n-----END CERTIFICATE-----\n" | |||
| "caCertificate": "-----BEGIN CERTIFICATE-----\nMIIEZzCCAk8CFFgTlrKabPLuSTRvTrym3/0Nl5O9MA0GCSqGSIb3DQEBCwUAMHAx\nCzAJBgNVBAYTAlhYMRUwEwYDVQQHDAxEZWZhdWx0IENpdHkxHDAaBgNVBAoME0Rl\nZmF1bHQgQ29tcGFueSBMdGQxLDAqBgNVBAMMI21vY2stc2VydmVyLWh0dHBzLXNl\nbGYtc2lnbmVkLXByb3h5MB4XDTIwMTEzMDE5NDA1NFoXDTQ4MDQxNzE5NDA1NFow\ncDELMAkGA1UEBhMCWFgxFTATBgNVBAcMDERlZmF1bHQgQ2l0eTEcMBoGA1UECgwT\nRGVmYXVsdCBDb21wYW55IEx0ZDEsMCoGA1UEAwwjbW9jay1zZXJ2ZXItaHR0cHMt\nc2VsZi1zaWduZWQtcHJveHkwggEiMA0GCSqGSIb3DQEBAQUAA4IBDwAwggEKAoIB\nAQDDf+vS3gnOU8dibGh1VTrEPry172oWPEp4Ybn31h5+NWpnmKWufGRc3HeZ0/cJ\nJ4V4HQmiCXc6yGxStx3EMaGT11DzSvbguZChSj+DxckFgxuox4wL7bOzScM/yWkL\nBK21wxLl92RiKlgBvdt3bDyJbOraxGSKBNRBBLM6Wh1JWc06YxF44e0T3B7H/Qtn\nWPXmsi1YPbYAxlkeoeJ6WNwfzEuLMnFf/fWgL2TgFwLIfhqOzlyU2CyHSAhOX3Ny\n5x3wIMxdT51MW601iCKhdluN6aNM0lTgHNAiz7RD0ZFtqWDN0XvOzTU+7jxA0926\nqtk18g9XU9R3WDNw1p6FNbdrAgMBAAEwDQYJKoZIhvcNAQELBQADggIBAFWQJM3l\nWimy7DYKn3Dy1RH9Pd4mIT0TJ4V1T/eszbWB7YRDdHuYyf7Sk0QDZPLMqR2sYxMc\nShdrQpOgU/o/iIkhwAjW6LzbuiQJULd74u3J08RPAEpSSJFJwQD4ZU2B7nhoqxft\noxUzoytfUSnsMA2EUJFYsPvkygyCihudNR+44ONq771W9HfvFNH3YdQyxjI/RtwT\nCiYdxQFiS5UvWCBbJAVmRWLm1gnJbG+MYBye4mGfyiZ3iMq/Wnb++favC8jNDYSO\nokha+LQBpscQZ3fbn5srh7uQGXOkQjT8gsd31neEFfXbVlrnUsHAXMHHgUgNrF+k\nPVp0321fzmvwxGwjB4/jHd+1ImDwcDJ6LseKwtbriN5EDbwEV/mIME2/MjFfqFhV\nM3AkhgW/sY4KvAD+FZ77U3xR4iIQgknjAPEYgqKDHF0h0295fwhRl7wmw/nO6Z8e\nIHP+YOH7gcdYskr2cnXXD9J2z0T3/VZUyZjnrmVqCdWq4hggea1qKYw6qHbtuETV\n9CCxLE+LTrFfYHHkQI2Jg8E+NDApjOodFoSaLphTzK8FZoyn9ttrR8UcFFMW95nt\n9POau3WtvfYvAve0h4UYj9ZMotNnTFWyhmgn9gu6gvuyVfvUKJlsW+KQbJ8bJraN\n0SLVT2nUF/WUpJde3jvWs+OtQCQEUZds5qfy\n-----END CERTIFICATE-----\n" | |||
There was a problem hiding this comment.
To se meni kvuli tomu updatu PHP? Neprestanout pak fungovat nejake certifikaty?
There was a problem hiding this comment.
@odinuv nie, len ked som tam minule pridaval ten certifikat - novy test ... tak som mu musel nastavit malu platnost, ... a teraz mi padal test, ze certifikat uz neplati (aj ked je self-signed, ale musi platit) .... tak som tie certifikaty iba pregeneroval na 10000 days, nesuvisi to s nicim inym.
| "squizlabs/php_codesniffer": "^3.0", | ||
| "phpstan/phpstan": "^0.7" | ||
| "phpstan/phpstan": "^0.8" |
There was a problem hiding this comment.
nejde tam dat rovnou posledni, nebo to je hodne zmen?
There was a problem hiding this comment.
neskusal som to, ale zo skusenosti s inymi komponentami je to vela zmien ... a kedze musim dorucit nejake veci pre CSAS, tak som si nemohol tomu dovolit venovat viac casu.
| @@ -1,4 +1,4 @@ | |||
| FROM php:7.1 | |||
| FROM php:7.2 | |||
There was a problem hiding this comment.
7.4? nebo to nejde? aspon bych na to zalozil jestli to nejde hned
There was a problem hiding this comment.
ok, zalozim task, chcel som ist cestou najmensieho rizika.
https://keboola.atlassian.net/browse/COM-554
eddycek
approved these changes
Dec 1, 2020
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: https://keboola.atlassian.net/browse/COM-552
Changes:
symfony/validatorBaseUrlis now validated by Symfony URL validator, so_underscore is allowed also in domain part of the url.