Fix types, explicitly define type #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaljurecko
force-pushed
the
webrouse-COM-622-fix-types
branch
from
455993e to
1366fc3
Compare
michaljurecko
commented
Jan 13, 2021
| @@ -5,7 +5,7 @@ php --version | |||
|
|
|||
| echo "Starting tests" >&1 | |||
| ./vendor/bin/phpcs -n --ignore=vendor,.tmp --extensions=php . | |||
| ./vendor/bin/phpstan analyse --level=max --no-progress -c phpstan.neon Client Config Exception Pagination Parser Tests | |||
| php -d memory_limit=2G ./vendor/bin/phpstan analyse --level=max --no-progress -c phpstan.neon Client Config Exception Pagination Parser Tests | |||
There was a problem hiding this comment.
Phpstanu uz nestacila pamat.
| @@ -125,6 +125,6 @@ private function getParams(JobConfig $jobConfig): array | |||
| private function getLimit(JobConfig $jobConfig): int | |||
| { | |||
| $params = $jobConfig->getParams(); | |||
| return empty($params[$this->limitParam]) ? $this->limit : $params[$this->limitParam]; | |||
| return empty($params[$this->limitParam]) ? $this->limit : (int) $params[$this->limitParam]; | |||
There was a problem hiding this comment.
Tu bol problem -> doplnil som pretypovanie, klient tam daval string, a skontroloval som aj ostatne miesta, kde by sa hodilo pretypovanie.
| 'endpoint' => 'test', | ||
| 'params' => [ | ||
| 'startAt' => 3, | ||
| 'limit' => (string) $limit, |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: https://keboola.atlassian.net/browse/COM-622