Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

TriggerAuthentication/Vault: add support for vault namespace #2084

Closed
chapurlatn opened this issue Sep 1, 2021 · 1 comment
Closed

TriggerAuthentication/Vault: add support for vault namespace #2084

chapurlatn opened this issue Sep 1, 2021 · 1 comment
Labels
feature-request All issues for new features that have not been committed to needs-discussion

Comments

@chapurlatn
Copy link
Contributor

chapurlatn commented Sep 1, 2021

Proposal

Support TriggerAuthentication for Vault Enterprise. For now, the Vault namespace feature can not be operate by TriggerAuthentication.

In the TriggerAuthentication spec, add an optional "spec.hashiCorpVault.namespace" in order to be compliant with all Vault install (and update the Vault authentication sequence accordingly).

Currently, it's not possible to setup a Vault TriggerAuthentication when using a namespace-based Vault server.
I could be useful to provide, in the spec, an optional "spec.hashiCorpVault.namespace" in order to be compliant with all Vault install.

Notes:
I checked Keda code and the corresponding handler do not implement namespace handling (https://github.com/kedacore/keda/blob/main/pkg/scaling/resolver/hashicorpvault_handler.go).
Here's an example of how to support namespace: https://github.com/hashicorp/vault/blob/main/api/client.go#L486

Use-Case

This allow to perform Vault authentication on a Vault Enterprise platform organized with isolated namespaces.
This way, any team in some organization can manage its own Keda trigger authentication within its own Vault namespace.

Anything else?

Useful links:

Relates to #2080

@zroubalik
Copy link
Member

fixed in #2085

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
feature-request All issues for new features that have not been committed to needs-discussion
Projects
None yet
Development

No branches or pull requests

2 participants