Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

TriggerAuthentication/Vault: add support for vault namespace #522

Merged
merged 1 commit into from
Sep 10, 2021

Conversation

chapurlatn
Copy link
Contributor

@chapurlatn chapurlatn commented Sep 1, 2021

Signed-off-by: Nicolas Chapurlat nc@coorganix.com

Changes

Related to keda PR kedacore/keda#2085

  • Just add the optional Vault namespace in the Vault TriggerAuthentication example.

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Relates to kedacore/keda#2084

Copy link
Member

@tomkerkhove tomkerkhove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! It will just need a bit more changes.

Signed-off-by: Nicolas Chapurlat <nc@coorganix.com>
Copy link
Member

@tomkerkhove tomkerkhove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@tomkerkhove
Copy link
Member

Waiting for feature to merge first.

@zroubalik zroubalik merged commit da62385 into kedacore:master Sep 10, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants