Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

In KEDA Metrics Server use OpenAPI definitions from custom-metrics-apiserver instead. #3929

Closed
zroubalik opened this issue Nov 29, 2022 · 0 comments · Fixed by #3928
Closed

In KEDA Metrics Server use OpenAPI definitions from custom-metrics-apiserver instead. #3929

zroubalik opened this issue Nov 29, 2022 · 0 comments · Fixed by #3928
Labels
feature-request All issues for new features that have not been committed to needs-discussion

Comments

@zroubalik
Copy link
Member

Proposal

custom-metrics-apiserver serves OpenAPI spec by default since version v1.25.0 (cf kubernetes-sigs/custom-metrics-apiserver#110).

In KEDA Metrics Server, remove generation of adapter/generated/openapi/zz_generated.openapi.go and use OpenAPI definitions from custom-metrics-apiserver instead.

Use-Case

No response

Anything else?

No response
@zroubalik zroubalik added needs-discussion feature-request All issues for new features that have not been committed to labels Nov 29, 2022
@zroubalik zroubalik moved this to Proposed in Roadmap - KEDA Core Nov 29, 2022
@zroubalik zroubalik moved this from Proposed to In Review in Roadmap - KEDA Core Nov 29, 2022
@olivierlemasle olivierlemasle mentioned this issue Nov 29, 2022
Merged
2 tasks
Repository owner moved this from In Review to Ready To Ship in Roadmap - KEDA Core Nov 29, 2022
@tomkerkhove tomkerkhove moved this from Ready To Ship to Done in Roadmap - KEDA Core Dec 9, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
feature-request All issues for new features that have not been committed to needs-discussion
Projects
Roadmap - KEDA Core
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Metrics Server: use vendored OpenAPI definitions olivierlemasle/keda
1 participant
@zroubalik