Metrics Server: use vendored OpenAPI definitions #3928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
custom-metrics-apiserver serves OpenAPI spec by default since version [v1.25.0] (cf [PR 110]). [v1.25.0]: https://github.com/kubernetes-sigs/custom-metrics-apiserver/releases/tag/v1.25.0 [PR 110]: kubernetes-sigs/custom-metrics-apiserver#110 In Keda Metrics Server, remove generation of `adapter/generated/openapi/zz_generated.openapi.go` and use OpenAPI definitions from custom-metrics-apiserver instead. Signed-off-by: Olivier Lemasle <olivier.lemasle@apalia.net>
olivierlemasle
force-pushed
the
use-custom-metrics-apiserver-openapi-def
branch
from
134387b to
66e0497
Compare
|
/run-e2e aws* |
zroubalik
reviewed
Nov 29, 2022
Co-authored-by: Zbynek Roubalik <zroubalik@gmail.com> Signed-off-by: Olivier Lemasle <o.lemasle@gmail.com>
|
/run-e2e internals* |
josephangbc
pushed a commit
to josephangbc/keda
that referenced
this pull request
Dec 6, 2022
* Metrics Server: use vendored OpenAPI definitions custom-metrics-apiserver serves OpenAPI spec by default since version [v1.25.0] (cf [PR 110]). [v1.25.0]: https://github.com/kubernetes-sigs/custom-metrics-apiserver/releases/tag/v1.25.0 [PR 110]: kubernetes-sigs/custom-metrics-apiserver#110 In Keda Metrics Server, remove generation of `adapter/generated/openapi/zz_generated.openapi.go` and use OpenAPI definitions from custom-metrics-apiserver instead. Signed-off-by: Olivier Lemasle <olivier.lemasle@apalia.net> * Update CHANGELOG.md Co-authored-by: Zbynek Roubalik <zroubalik@gmail.com> Signed-off-by: Olivier Lemasle <o.lemasle@gmail.com> Signed-off-by: Olivier Lemasle <olivier.lemasle@apalia.net> Signed-off-by: Olivier Lemasle <o.lemasle@gmail.com> Co-authored-by: Zbynek Roubalik <zroubalik@gmail.com>
josephangbc
pushed a commit
to josephangbc/keda
that referenced
this pull request
Dec 6, 2022
* Metrics Server: use vendored OpenAPI definitions custom-metrics-apiserver serves OpenAPI spec by default since version [v1.25.0] (cf [PR 110]). [v1.25.0]: https://github.com/kubernetes-sigs/custom-metrics-apiserver/releases/tag/v1.25.0 [PR 110]: kubernetes-sigs/custom-metrics-apiserver#110 In Keda Metrics Server, remove generation of `adapter/generated/openapi/zz_generated.openapi.go` and use OpenAPI definitions from custom-metrics-apiserver instead. Signed-off-by: Olivier Lemasle <olivier.lemasle@apalia.net> * Update CHANGELOG.md Co-authored-by: Zbynek Roubalik <zroubalik@gmail.com> Signed-off-by: Olivier Lemasle <o.lemasle@gmail.com> Signed-off-by: Olivier Lemasle <olivier.lemasle@apalia.net> Signed-off-by: Olivier Lemasle <o.lemasle@gmail.com> Co-authored-by: Zbynek Roubalik <zroubalik@gmail.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
custom-metrics-apiserver serves OpenAPI spec by default since version v1.25.0 (cf PR 110).
In KEDA Metrics Server, remove generation of
adapter/generated/openapi/zz_generated.openapi.goand use OpenAPI definitions from custom-metrics-apiserver instead.Checklist
deployment manifests are modified)*
Fixes #3929