-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add Bearer Auth for Metrics API scaler #2028
Conversation
Signed-off-by: jorturfer <jorge_turrado@hotmail.es>
Signed-off-by: jorturfer <jorge_turrado@hotmail.es>
I'm not sure if it's better to create a new Maybe |
JWT would be a specific case, or format, of a bearer token, right? I'm assuming the value of |
I'd say that the JWT would just be the JWT token and we add the bearer for you, no? |
I'm not an expert here, but I think that JWT is more like the format and Bearer is one use case of the format, but as I said, I'm not an expert :( |
This remark is purely from a user-perspective and making it simple/straight-forward - Not saying this is how JWT works |
Maybe the auth method should be named as |
I like this approach. |
Signed-off-by: jorturfer <jorge_turrado@hotmail.es>
I have just changed it @zroubalik :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :)
@JorTurFer one merge conflict in |
|
Signed-off-by: jorturfer <jorge_turrado@hotmail.es>
* Add support to jwt token in metrics api scaler Signed-off-by: jorturfer <jorge_turrado@hotmail.es> * Add test Signed-off-by: jorturfer <jorge_turrado@hotmail.es> * Update changelog Signed-off-by: jorturfer <jorge_turrado@hotmail.es> * Update auth method and add test Signed-off-by: jorturfer <jorge_turrado@hotmail.es> Signed-off-by: nilayasiktoprak <nilayasiktoprak@gmail.com>
Adds an authorization method named
bearer
for Metrics API scalerChecklist
Relates to #1081