-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Graphite Scaler + e2e tests #2092
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
01f42f7
to
669a451
Compare
7440a1a
to
899b195
Compare
nmische
reviewed
Sep 6, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @bpinske! I had started to look at the e2e tests a couple of times but had yet to make much progress.
nmische
reviewed
Sep 7, 2021
6e9b257
to
95fcb43
Compare
zroubalik
reviewed
Sep 10, 2021
c286084
to
54e0783
Compare
zroubalik
reviewed
Sep 13, 2021
7a5e4f0
to
aff37c6
Compare
Co-authored-by: 刘烁 <shuo.liu@leyantech.com> Co-authored-by: Tom Kerkhove <kerkhove.tom@gmail.com> Signed-off-by: shuoliu1 shuo_liu1@163.com Signed-off-by: Brandon Pinske <brandon@pinske.info> Signed-off-by: Brandon Pinske <brandon.pinske@crowdstrike.com>
aff37c6
to
c28f28f
Compare
Signed-off-by: Brandon Pinske <brandon@pinske.info> Signed-off-by: Brandon Pinske <brandon.pinske@crowdstrike.com>
c28f28f
to
7c73477
Compare
zroubalik
reviewed
Sep 14, 2021
Signed-off-by: Brandon Pinske <brandon.pinske@crowdstrike.com>
Signed-off-by: Brandon Pinske <brandon.pinske@crowdstrike.com>
zroubalik
approved these changes
Sep 15, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @bpinske for completing this feature!
nilayasiktoprak
pushed a commit
to nilayasiktoprak/keda
that referenced
this pull request
Oct 23, 2021
Co-authored-by: shuoliu1 <shuo_liu1@163.com> Co-authored-by: 刘烁 <shuo.liu@leyantech.com> Co-authored-by: Tom Kerkhove <kerkhove.tom@gmail.com> Co-authored-by: Brandon Pinske <brandon.pinske@crowdstrike.com> Signed-off-by: shuoliu1 shuo_liu1@163.com Signed-off-by: Brandon Pinske <brandon@pinske.info> Signed-off-by: Brandon Pinske <brandon.pinske@crowdstrike.com> Signed-off-by: nilayasiktoprak <nilayasiktoprak@gmail.com>
bpinske
added a commit
to bpinske/keda
that referenced
this pull request
Jan 19, 2022
Co-authored-by: shuoliu1 <shuo_liu1@163.com> Co-authored-by: 刘烁 <shuo.liu@leyantech.com> Co-authored-by: Tom Kerkhove <kerkhove.tom@gmail.com> Co-authored-by: Brandon Pinske <brandon.pinske@crowdstrike.com> Signed-off-by: shuoliu1 shuo_liu1@163.com Signed-off-by: Brandon Pinske <brandon@pinske.info> Signed-off-by: Brandon Pinske <brandon.pinske@crowdstrike.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support scaling by Graphite Metrics
Checklist
Graphite scaler docs keda-docs#524
Fixes #1628