Support poolName or poolID validation in Azure Pipelines Scaler
#2370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jorturfer <jorge_turrado@hotmail.es>
|
Would you mind adding an issue for this @JorTurFer? Instead of using one or the other, maybe we should allow them to configure both and use what they want to use? |
|
Ok this is probably related to #2342 |
Yes it is, I forgot adding the link :( |
Signed-off-by: jorturfer <jorge_turrado@hotmail.es>
JorTurFer
changed the title
poolName instead of poolID in Azure Pipelines ScalerpoolName or poolID validation in Azure Pipelines Scaler
JorTurFer
changed the title
poolName or poolID validation in Azure Pipelines ScalerpoolName or poolID validation in Azure Pipelines Scaler
Signed-off-by: jorturfer <jorge_turrado@hotmail.es>
JorTurFer
force-pushed
the
azure_devops
branch
from
511eb0c to
bc90806
Compare
Signed-off-by: jorturfer <jorge_turrado@hotmail.es>
Signed-off-by: jorturfer <jorge_turrado@hotmail.es>
Signed-off-by: jorturfer <jorge_turrado@hotmail.es>
Signed-off-by: jorturfer <jorge_turrado@hotmail.es>
Signed-off-by: jorturfer <jorge_turrado@hotmail.es>
Signed-off-by: jorturfer <jorge_turrado@hotmail.es>
Signed-off-by: jorturfer <jorge_turrado@hotmail.es>
Signed-off-by: jorturfer <jorge_turrado@hotmail.es>
|
/run-e2e azure-pipelines.test* |
1 task
zroubalik
reviewed
Jan 3, 2022
Co-authored-by: Zbynek Roubalik <726523+zroubalik@users.noreply.github.com> Signed-off-by: Jorge Turrado <jorge.turrado@docplanner.com>
alex60217101990
pushed a commit
to dysnix/keda
that referenced
this pull request
Jan 10, 2022
…edacore#2370) Signed-off-by: Jorge Turrado <jorge.turrado@docplanner.com> Co-authored-by: Zbynek Roubalik <726523+zroubalik@users.noreply.github.com> Signed-off-by: alex60217101990 <alex6021710@gmail.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: jorturfer jorge_turrado@hotmail.es
Provide a description of what has been changed
Checklist
poolNameorpoolIDvalidation in Azure Pipelines Scaler keda-docs#612Relates to #2342