-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Allow using simple queue names in aws sqs scaler #2483
Conversation
3bec0ca
to
0f269f3
Compare
Hi @nicolaferraro , |
I see you've checked " A PR is opened to update the documentation on (repo) (if applicable)" but I don't see a PR on https://github.com/kedacore/keda-docs/pulls?q=is%3Apr+is%3Aopen+sort%3Aupdated-desc. Would you mind updating the docs for 2.6 please? |
Yes, I thought it wasn't required, but I've opened this: kedacore/keda-docs#628. Sure, I've tested it manually and using the new integration I've created in Camel K. |
Signed-off-by: nicolaferraro <ni.ferraro@gmail.com>
0f269f3
to
181a079
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thanks for your contribution ❤️
Added concern on doc PR given we are re-using the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Signed-off-by: nicolaferraro <ni.ferraro@gmail.com> Signed-off-by: Mark Rzasa <mark.rzasa@gmail.com>
Signed-off-by: nicolaferraro <ni.ferraro@gmail.com> Signed-off-by: Mark Rzasa <mark.rzasa@gmail.com>
AWS SQS autoscaler does not really need a full queueURL, it also works with simple queue names, but there was some code that tried to parse the URL to get the queue name for building a metric ID.
The example in the doc already uses a simple name.
Checklist
Fixes #