Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Sign main tag and add missing env during release workflow #2502

Merged
merged 3 commits into from
Jan 21, 2022
Merged

Sign main tag and add missing env during release workflow #2502

merged 3 commits into from
Jan 21, 2022

Conversation

JorTurFer
Copy link
Member

@JorTurFer JorTurFer commented Jan 21, 2022 •
edited
Loading

Signed-off-by: jorturfer jorge_turrado@hotmail.es

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Tests have been added
  • A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
  • A PR is opened to update the documentation on (repo) (if applicable)
  • Changelog has been updated

Related #2501

@JorTurFer
sign main tag and add missing env in release workflow
faeed9c 
Signed-off-by: jorturfer <jorge_turrado@hotmail.es>
@JorTurFer JorTurFer requested a review from a team as a code owner January 21, 2022 17:30
@JorTurFer
Update changelog
b319cc4 
Signed-off-by: jorturfer <jorge_turrado@hotmail.es>
zroubalik
zroubalik reviewed Jan 21, 2022
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is extra whitespace

@JorTurFer
Copy link
Member Author

JorTurFer commented Jan 21, 2022 •
edited
Loading

I'm AFK, I'll update it in 40-50 min.

@JorTurFer
Fix styles
096d4cc 
Signed-off-by: jorturfer <jorge_turrado@hotmail.es>
@JorTurFer
Copy link
Member Author

These f******* whitespaces... 🤣 🤣 🤣
Solved

@zroubalik
Copy link
Member

These f******* whitespaces... 🤣 🤣 🤣 Solved

@JorTurFer btw you can enable pre-commit locally, so you catch these kind of issues before commiting the actual code.

@JorTurFer
Copy link
Member Author

JorTurFer commented Jan 21, 2022 •
edited
Loading

I got it... but disabled because the tools are only installed inside the dev container, I should install them also in the host. Probably when my new computer arrives, I'll do something more reliable xD (usually I run it manually, but sometimes I forget it)

Anyway, thanks for the suggestion ❤️

@zroubalik zroubalik merged commit ba37a17 into kedacore:main Jan 21, 2022
@JorTurFer JorTurFer deleted the sign_main branch January 21, 2022 19:29
@JorTurFer JorTurFer mentioned this pull request Jan 21, 2022
Merged
5 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@zroubalik zroubalik zroubalik approved these changes

@tomkerkhove tomkerkhove tomkerkhove approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JorTurFer @zroubalik @tomkerkhove